On Fri, Dec 19, 2014 at 1:56 PM, 宋文武 <iyzs...@gmail.com> wrote: > FYI, every apps will install icons into 'hicolor-icon-theme', > for it to work, we need regenerated the 'icon-theme.cache' > by `gtk-update-icon-cache`.
The icon packages that I looked into are generating the cache by themselves at installation. In any case, I think we can add a check similar to one we do for schemas, just in case some icon packages do not generate the cache. > We should avoid hardcoding guix-profile or current-system to packages. > IMO, for those kind of things, a better place would be '/etc/profile'. > > And, apps will crash when user has incompatible gio modules, See: > > https://github.com/NixOS/nixpkgs/issues/1357 I agree, keeping the guix-profile out is actually increasing flexibility. Thanks for the review and the suggestions! I will update the patch accordingly. Regards, Fede
