On Mon, Dec 15, 2014 at 11:16 PM, Ludovic Courtès <l...@gnu.org> wrote:
> Federico Beffa <be...@ieee.org> skribis:
>
>> From f4187d31f95e3a65947d77bf267115906ed3816b Mon Sep 17 00:00:00 2001
>> From: Federico Beffa <be...@fbengineering.ch>
>> Date: Wed, 10 Dec 2014 20:36:58 +0100
>> Subject: [PATCH 2/4] gnu: Add xcffib
>>
>> * gnu/packages/python.scm (python-xcffib, python2-xcffib): New variables.
>
> [...]
>
>> + (propagated-inputs
>> + `(("python-cffi" ,python-cffi)))
>
> Please add a comment saying why this is propagated.
>
>> + (synopsis "XCB Python binding")
>
> “bindings” (plural)
>
>> + (description
>> + "A drop in replacement for xpyb, an XCB python binding.")
>
> “drop-in”, “Python”, “bindings”.
>
> Could you expound the description a little bit?
Please find attached an updated patch. Regarding the description: I've
tried to expand it a little, but, to be honest, I do not know much
about this package. I copied the description from the web site. I only
packaged it because it is used by other packages I'm interested in :-)
Regards,
Fede
From 2b7df0f474c1e57eb31a81693500b686d177f3a1 Mon Sep 17 00:00:00 2001
From: Federico Beffa <be...@fbengineering.ch>
Date: Wed, 10 Dec 2014 20:36:58 +0100
Subject: [PATCH 2/4] gnu: Add xcffib
* gnu/packages/python.scm (python-xcffib, python2-xcffib): New variables.
---
gnu/packages/python.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 67effe7..c2657f2 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -50,6 +50,7 @@
#:use-module (gnu packages fontutils)
#:use-module (gnu packages which)
#:use-module (gnu packages perl)
+ #:use-module (gnu packages xorg)
#:use-module (guix packages)
#:use-module (guix download)
#:use-module (guix git-download)
@@ -2541,3 +2542,45 @@ a front-end for C compilers or analysis tools.")
(define-public python2-cffi
(package-with-python2 python-cffi))
+
+(define-public python-xcffib
+ (package
+ (name "python-xcffib")
+ (version "0.1.9")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://pypi.python.org/packages/source/x/";
+ "xcffib/xcffib-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0655hzxv57h1a9ja9kwp0ichbkhf3djw32k33d66xp0q37dq2y81"))))
+ (build-system python-build-system)
+ (inputs
+ `(("libxcb" ,libxcb)
+ ("python-six" ,python-six)))
+ (native-inputs
+ `(("python-setuptools" ,python-setuptools)))
+ (propagated-inputs
+ `(("python-cffi" ,python-cffi))) ; used at run time
+ (arguments
+ `(#:phases
+ (alist-cons-after
+ 'install 'install-doc
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((doc (string-append (assoc-ref outputs "out") "/share"
+ "/doc/" ,name "-" ,version)))
+ (mkdir-p doc)
+ (copy-file "README.md"
+ (string-append doc "/README.md"))))
+ %standard-phases)))
+ (home-page "https://github.com/tych0/xcffib";)
+ (synopsis "XCB Python bindings")
+ (description
+ "Xcffib is a replacement for xpyb, an XCB Python bindings. It adds
+support for Python 3 and PyPy. It is based on cffi.")
+ (license expat)))
+
+(define-public python2-xcffib
+ (package-with-python2 python-xcffib))
+
--
1.8.4
