I've tried this patch and it has been built successfully on my i686 machine.
So only nitpickings from me.
John Darrington (2014-12-14 13:48 +0300) wrote:
[...]
> + (arguments
> + '(#:tests? #f ; Test suite requires a lot of black magic
> + #:phases
Trailing space ↑
> + (alist-replace 'configure
Another one ↑
> + (lambda* (#:key outputs #:allow-other-keys #:rest args)
> + (setenv "PREFIX" (assoc-ref outputs "out"))
> + (setenv "LDFLAGS" (string-append "-Wl,-rpath="
Double space ↑↑
> + (assoc-ref %outputs
> "out") "/lib"))
Not aligned properly and this line is too long ↑
> +
> + (setenv "CC" "gcc"))
> + %standard-phases)))
> + (native-inputs `(("perl" ,perl))) ; for pod2man
> + (inputs `(("libx11" ,libx11)
> + ("libxext" ,libxext)
> + ("libxi" ,libxi)
> + ("libxinerama" ,libxinerama)
> + ("libxtst" ,libxtst)))
> + (home-page "http://www.semicomplete.com/projects/xdotool";)
> + (synopsis "Fake keyboard/mouse input, window management, and more")
> + (description "Xdotool lets you simulate keyboard input and mouse
> activity,
> +move and resize windows, etc. It does this using X11's XTEST extension and
Single space ↑
> +other Xlib functions. Additionally, you can search for windows and move,
> +resize, hide, and modify window properties like the title. If your window
Single space ↑
> +manager supports it, you can use xdotool to switch desktops, move windows
> +between desktops, and change the number of desktops.")
> + (license license:bsd-3)))
IIUC using double spaces in the end of sentences is a convention. Also
I noticed that you make descriptions look like this:
(description "…")
This makes the first line significantly shorter than other ones, so some
people (including me) prefer the following variant:
(description
"…")
What about making a convention on how "description" fields should look.
Ludo?
--
Alex
