"Taylan Ulrich Bayırlı/Kammer" <taylanbayi...@gmail.com> writes:
> David Thompson <dthomps...@worcester.edu> writes: > >> Please break this into 2 commits, one for each new package. > > rTorrent and its libTorrent kind of belong together, though I guess > they're strictly speaking separate packages... Yes, they belong together, but it's best to have small, focused patches. >>> + (home-page "http://nmap.org/";) >> >> Should be "http://libtorrent.rakshasa.no/"; > > Whoops, too much copy & paste. :-) > > (I'm working on an nmap recipe too.) I figured. I've made that mistake, too. > Here's the new patches. By the way the first does not strictly need the > "#:use-module (gnu packages check)" since cppunit is commented out for > now, but I left it there; is that OK? Might be best to move that line to the patch that adds rtorrent, for cleanliness. The new patches look good to me. Let's see what Ludo thinks. :) -- David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate
