Cyril Roelandt writes: > On 10/24/2014 07:06 AM, Eric Bavier wrote: >> From 94794a8cb470238f60db977b7640202517d379c4 Mon Sep 17 00:00:00 2001 >> From: Eric Bavier <bav...@member.fsf.org> >> Date: Wed, 22 Oct 2014 13:48:55 -0500 >> Subject: [PATCH 4/5] guix: lint: Check for empty synopses and descriptions. >> >> * guix/scripts/lint.scm (check-description-style, >> check-synopsis-style): New emptiness checks. >> * tests/lint.scm: Test them. >> --- >> guix/scripts/lint.scm | 14 ++++++++++++++ >> tests/lint.scm | 18 ++++++++++++++++++ >> 2 files changed, 32 insertions(+) > > > Should we also check for descriptions that are just #f ? There are a few > valid cases, but in general, it's an issue. WDYT ?
We may want to. I think what we're trying to catch is the case where a developer initially put a placeholder in, but might have forgotten to go back fill the field in with a proper string. Depending on the developer's taste, the placeholder might be an empty string, or #f. I'll try out the #f check, and see if it runs into any problems. -- Eric Bavier Please avoid sending me Word or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html
