Cyril Roelandt <tipec...@gmail.com> skribis:

> * guix/scripts/lint.scm (check-description-style, 
> check-synopsis-start-upper-case): New methods
> * tests/lint.scm: Test them.

Please specify the test names, and wrap lines.

> +(define (start-with-upper-case s)
> +  (char-set-contains? char-set:upper-case (string-ref s 0)))

Rather ‘starts-with-capital-letter?’ (with the question mark, as is
conventional, and more grammatically correct I think.)

Also it may be worth checking that S has one or more character, so
gracefully handle empty synopses.

OK to push with these changes, thanks!

Ludo’.

Reply via email to