On 9/15/14, Alex Kost <alez...@gmail.com> wrote:
> Hello, I don't have real comments, I just noticed a couple of typos.
Thanks :)
>>
>> * gnu/packages/pdf.scm (mupdf): New variable.
>> * gnu/packages/patches/mupdf-buildsystem-fix.patch: New vile.
>
> New file.
>
Yup.
>
> 5 * trailing space.
>
They were generated by diff, won't removing them break the patch?
>
>> + (inputs
>> + `(("curl" ,curl)
>> + ("freetype", freetype)
>
> ("freetype" ,freetype)
>
Yup.
>
>> + (synopsis "A lightweight PDF viewer and toolkit.")
>> + (description
>> + "MuPDF is a C library that implements a PDF and XPS parsing and
>> rendering
>> +engine. It is used primarily to render pages into bitmaps, but also
>> provides
>> +support for other operations such as searching and listing the table of
>> +contents and hyperlinks.
>> +
>> +The library ships with a rudimentary X11 viewer, and a set of command
>> line tools
>> +for batch rendering (pdfdraw), examining the file structure (pdfshow),
>> and
>> +rewriting files (pdfclean).")
>> + (license license:agpl3+)))
>
> I think people usually avoid a period in a synopsis and use a double
> space after a period in a description. Also the description should be
> wrapped by 72 (or 78?) characters in a line.
Yup. Thanks for the reply, I'll try to fix the patch, but I don't know
about the trailing spaces, I kind of don't want to touch diff's
output.
