Alex Kost <alez...@gmail.com> skribis: > - A part of code for installing/upgrading/removing was extracted from > ‘guix-package’ function (from ‘process-actions’ more precisely). So > the new function (I named it ‘process-package-actions’) can be used in > "guix.el".
That looks good, but could you make it a separate patch? In general, it’s better to send atomic changes, with a commit log, in the format produced by ‘git format-patch’ (see HACKING.) That facilitates review and incremental changes. > - A bit of code was placed into "profiles.scm" as ‘manifest-add’. Good idea. Could you send a single patch for this change? I’ll even add a couple of test cases in tests/profiles.scm for the new procedure if you don’t do it yourself. :-) > - Also I think you forgot (?) to remove ‘deduplicate’ function in commit > 4ca0b41, so I did it as well. Indeed, I’ve just removed it and a couple others. Somehow I thought we were compiling with -Wunused-toplevel. Thanks, Ludo’.
