> I believe the ‘modules’ field can be omitted.
Done, I forgot to do that in the first place :P
>
>> + (propagated-inputs `(("gnumach-headers" ,gnumach-headers)
>> + ("hurd-headers" ,hurd-headers)
>> + ("hurd-minimal" ,hurd-minimal)))
>
> Add a one-line comment saying why they’re propagated.
Actually I am not sure, should they be propagated? Linux glibc does it
this way, because
> ;; Glibc's <limits.h> refers to <linux/limit.h>, for instance, so glibc
> ;; users should automatically pull Linux headers as well.
Should I change it to inputs?
> Is --host the only thing that differs from ‘glibc’? If so, we need to
> factorize things.
In order for glibc/hurd to build, we need to remove
> (string-append "--with-headers="
> (assoc-ref %build-inputs "linux-headers")
> "/include")
> "--enable-kernel=2.6.30"
> ;; XXX: Work around "undefined reference to `__stack_chk_guard'".
> "libc_cv_ssp=no"
which are linux specific, and add
> "--host=i686-pc-gnu"
> "--disable-profile"
> "--disable-multi-arch"
> "--disable-nscd"
> "--enable-obsolete-rpc"
How do you suggest doing it? :-)
> However, why do the headers need to be copied in the first place? I
> believe the sysdeps headers of add-ons are automatically picked up the
> libc’s build system normally. Could you check what’s going on?
When these headers are included, they are used like that
> <bits/...>
so, while they are normally included in the path, it only looks in the
directory "bits/" for them not in libpthread/sysdeps/generic/bits/.
Any suggestions?
> Remove #t, otherwise the result of ‘zero?’ is ignored.
Done.
>> --- /dev/null
>> +++ b/gnu/packages/patches/glibc-manual-fix.patch
>> @@ -0,0 +1,12 @@
>> +diff --git a/manual/contrib.texi b/manual/contrib.texi
>> +index 3b9d23c..376b40d 100644
>> +--- a/manual/contrib.texi
>> ++++ b/manual/contrib.texi
>> +@@ -1,3 +1,4 @@
>> ++@end deftypefun
>> + @node Contributors, Free Manuals, Platform, Top
>> + @c %MENU% Who wrote what parts of the GNU C Library
>> + @appendix Contributors to @theglibc{}
>
> What’s this? (Missing explanation.)
Without this, I get the error
> ./contrib.texi:1: @node seen before @end deftypefun
Manolis
