Cyril Roelandt <tipec...@gmail.com> skribis:
> * gnu/packages/gtk.scm (atk, gdk-pixbuf, gtk+, pango): enable introspection
> * guix/build/gnome.scm: New file.
[...]
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -184,9 +184,10 @@ dynamic loading, and an object system.")
> ("cairo" ,cairo)
> ("flex" ,flex)
> ("glib" ,glib)
> - ("libffi" ,libffi)
> ("pkg-config" ,pkg-config)
> ("python-2" ,python-2)))
> + (propagated-inputs
> + `(("libffi" ,libffi)))
Please add a comment saying that GIR users need to use libffi (to use
its headers, right?), hence the propagation.
> +
> + (substitute* "gdk/Makefile.in"
> + (("--add-include-path=../gdk")
> + (string-append
> + "--add-include-path=../gdk"
> + " --add-include-path=" (gir-path inputs "gdk-pixbuf")
> + " --add-include-path=" (gir-path inputs "pango")))
Add a comment above saying what this is all about (what program these
flags are for, and what they do.)
> +(define-module (guix build gnome)
> + #:export (gir-path))
> +
> +;;; Commentary:
> +;;;
> +;;; Tools commonly used when building GNOME programs.
> +;;;
> +;;; Code:
> +
> +(define (gir-path inputs pkg-name)
> + ""
> + (string-append (assoc-ref inputs pkg-name)
> + "/share/gir-1.0"))
Please add a docstring here (instead of ""), like
Return the GIR directory name for PKG-NAME found from INPUTS.
So I think ‘gir-directory’ would be more appropriate.
OK to push with these things fixed.
Thanks,
Ludo’.
