guix_mirror_bot pushed a commit to branch go-team in repository guix. commit 3e49365caa5f612ebcd7e467fab15961554de48d Author: Sharlatan Hellseher <sharlata...@gmail.com> AuthorDate: Sun Jun 8 12:22:35 2025 +0100
gnu: Pin some golang packages to use go-1.23. After the defult Golang version was set to 1.24 some of the older packages which had no fresh version started failing on the 'check phase, this change pins them to go-1.23 helping to resolve the issue. Go 1.24 requires non-constant format strings to be explicitly handled. The error looks like this: non-constant format string in call to (*testing.common).Errorf See <https://tip.golang.org/doc/go1.24#vet>. Change-Id: Ife5093c4fd98af7cea59abf1a9a29351b66602bb --- gnu/packages/bioinformatics.scm | 2 ++ gnu/packages/education.scm | 2 ++ gnu/packages/file-systems.scm | 2 +- gnu/packages/golang-build.scm | 4 ++- gnu/packages/golang-check.scm | 16 +++++++++++- gnu/packages/golang-crypto.scm | 2 ++ gnu/packages/golang-maths.scm | 2 ++ gnu/packages/golang-web.scm | 26 +++++++++++++++--- gnu/packages/golang-xyz.scm | 58 +++++++++++++++++++++++++++++++++-------- 9 files changed, 96 insertions(+), 18 deletions(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index a119a13a6f..9a24fb9bb7 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -98,6 +98,7 @@ #:use-module (gnu packages gawk) #:use-module (gnu packages gcc) #:use-module (gnu packages gd) + #:use-module (gnu packages golang) #:use-module (gnu packages golang-build) #:use-module (gnu packages golang-check) #:use-module (gnu packages golang-compression) @@ -25394,6 +25395,7 @@ functions.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:skip-build? #t #:import-path "github.com/biogo/store")) (propagated-inputs diff --git a/gnu/packages/education.scm b/gnu/packages/education.scm index b03066b663..687ad6e65c 100644 --- a/gnu/packages/education.scm +++ b/gnu/packages/education.scm @@ -47,6 +47,7 @@ #:use-module (gnu packages gettext) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) + #:use-module (gnu packages golang) #:use-module (gnu packages golang-build) #:use-module (gnu packages golang-check) #:use-module (gnu packages golang-web) @@ -113,6 +114,7 @@ (build-system go-build-system) (arguments (list + #:go go-1.23 #:install-source? #f #:import-path "github.com/xalanq/cf-tool" #:phases diff --git a/gnu/packages/file-systems.scm b/gnu/packages/file-systems.scm index a89eed6dfb..a3315217be 100644 --- a/gnu/packages/file-systems.scm +++ b/gnu/packages/file-systems.scm @@ -2204,8 +2204,8 @@ memory-efficient.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/oniony/TMSU" - #:unpack-path "github.com/oniony/TMSU" #:install-source? #f #:phases #~(modify-phases %standard-phases diff --git a/gnu/packages/golang-build.scm b/gnu/packages/golang-build.scm index 117b16376c..cc12a5dbd7 100644 --- a/gnu/packages/golang-build.scm +++ b/gnu/packages/golang-build.scm @@ -44,7 +44,8 @@ #:use-module (guix packages) #:use-module (guix utils) #:use-module (gnu packages) - #:use-module (gnu packages gcc)) + #:use-module (gnu packages gcc) + #:use-module (gnu packages golang)) ;;; Commentary: ;;; @@ -388,6 +389,7 @@ primitives in Go.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/twitchyliquid64/golang-asm")) (home-page "https://github.com/twitchyliquid64/golang-asm") (synopsis "Assembler from the Go compiler, in library form") diff --git a/gnu/packages/golang-check.scm b/gnu/packages/golang-check.scm index 4ed02df429..12795ac1ac 100644 --- a/gnu/packages/golang-check.scm +++ b/gnu/packages/golang-check.scm @@ -49,6 +49,7 @@ #:use-module (guix git-download) #:use-module (guix utils) #:use-module (gnu packages) + #:use-module (gnu packages golang) #:use-module (gnu packages golang-build) #:use-module (gnu packages golang-xyz)) @@ -299,7 +300,9 @@ test (using testing.TB's @code{TempDir}) and with a few helper methods.") "1mkbyzhwq3rby832ikq00nxv3jnckxsm3949wkxd8ya9js2jmg4d")))) (build-system go-build-system) (arguments - '(#:import-path "github.com/cheekybits/is")) + (list + #:go go-1.23 + #:import-path "github.com/cheekybits/is")) (home-page "https://github.com/cheekybits/is") (synopsis "Mini testing helper for Go") (description "A mini testing helper for Go. @@ -441,6 +444,7 @@ strings which may be used in mock tests.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/DATA-DOG/go-sqlmock" #:phases #~(modify-phases %standard-phases @@ -945,6 +949,7 @@ package, but can be used in other contexts too.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/google/gofuzz" ;; Tests fail on 32bit #:tests? (target-64bit?))) @@ -1501,6 +1506,7 @@ output capturing, mocking, and much more.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/matryer/is")) (home-page "https://github.com/matryer/is") (synopsis "Lightweight testing mini-framework for Golang") @@ -1553,6 +1559,7 @@ Perl's @url{https://metacpan.org/pod/Test::Deep, Test::Deep perl}.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/onsi/ginkgo" #:test-flags #~(list "-skip" "TestIntegration"))) (propagated-inputs @@ -1667,6 +1674,7 @@ framework.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/otiai10/mint")) (home-page "https://github.com/otiai10/mint") (synopsis "Minimal assertion for Golang testing framework") @@ -1829,6 +1837,9 @@ GIT_TRACE mechanism.") (build-system go-build-system) (arguments (list + ;; See the list of supported Golang versions in + ;; <testify/.github/workflows/main.yml>. + #:go go-1.23 ;; XXX: Tests are shaky on non x86_64 architectures, check if some may ;; be enabled. #:tests? (target-x86-64?) @@ -2035,6 +2046,7 @@ test coverage and has a web user interface that will refresh automatically.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/smarty/assertions")) (home-page "https://github.com/smarty/assertions") (synopsis "Fluent assertion-style functions") @@ -2452,6 +2464,7 @@ custom assertions to be used alongside native Go testing.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/warpfork/go-testmark")) (propagated-inputs (list go-github-com-warpfork-go-fsx)) @@ -2482,6 +2495,7 @@ testmark} format, which itself is a subset of Markdown format.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/warpfork/go-wish" #:test-subdirs #~(list "cmp/..." "wishfix" ".") #:test-flags diff --git a/gnu/packages/golang-crypto.scm b/gnu/packages/golang-crypto.scm index 3be5588f3b..f741115828 100644 --- a/gnu/packages/golang-crypto.scm +++ b/gnu/packages/golang-crypto.scm @@ -388,6 +388,7 @@ with its management port enabled.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:skip-build? #t #:import-path "github.com/blanu/Dust")) (propagated-inputs @@ -568,6 +569,7 @@ described at @url{https://xxhash.com/}.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/chmduquesne/rollinghash/" #:phases #~(modify-phases %standard-phases diff --git a/gnu/packages/golang-maths.scm b/gnu/packages/golang-maths.scm index e84c1bdd88..7e0b7b75fa 100644 --- a/gnu/packages/golang-maths.scm +++ b/gnu/packages/golang-maths.scm @@ -25,6 +25,7 @@ #:use-module (guix git-download) #:use-module (guix packages) #:use-module (gnu packages) + #:use-module (gnu packages golang) #:use-module (gnu packages golang-build)) ;;; Commentary: @@ -200,6 +201,7 @@ flow into higher precision types from the @code{math.big} library.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/montanaflynn/stats" #:phases #~(modify-phases %standard-phases diff --git a/gnu/packages/golang-web.scm b/gnu/packages/golang-web.scm index 867a1bb98c..913b968b6c 100644 --- a/gnu/packages/golang-web.scm +++ b/gnu/packages/golang-web.scm @@ -736,6 +736,7 @@ functions.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/aws/aws-sdk-go" #:phases #~(modify-phases %standard-phases @@ -1489,6 +1490,7 @@ and RFC 5389).") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/cenkalti/backoff/v4")) (home-page "https://github.com/cenkalti/backoff") (synopsis "The exponential backoff algorithm in Go") @@ -3760,6 +3762,7 @@ APIs.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:skip-build? #t #:import-path "github.com/gogo/protobuf" ;; protoc: exec: "protoc-min-version": executable file not found in $PATH @@ -4030,7 +4033,9 @@ parameters.") (base32 "0j2xjy8xrk9y9k6bqpvimj84i6hg1wwsyvwsb0axhmp49cmnrp86")))) (build-system go-build-system) (arguments - '(#:import-path "github.com/google/safehtml")) + (list + #:go go-1.23 + #:import-path "github.com/google/safehtml")) (propagated-inputs (list go-golang-org-x-text)) (home-page "https://github.com/google/safehtml") @@ -4770,8 +4775,10 @@ authenticated identities and their attributes.") (base32 "1rv495j8j2x6avw5hqpf7rpiakr5gdsx6pv8rfn0ff7vi35zfa62")))) (build-system go-build-system) (arguments - '(#:import-path "github.com/jcmturner/gokrb5/v8" - #:unpack-path "github.com/jcmturner/gokrb5")) + (list + #:go go-1.23 + #:import-path "github.com/jcmturner/gokrb5/v8" + #:unpack-path "github.com/jcmturner/gokrb5")) (native-inputs (list go-github-com-stretchr-testify)) (propagated-inputs @@ -4933,7 +4940,9 @@ described in @url{https://www.rfc-editor.org/rfc/rfc959,RFC 959}.") (base32 "18zyr9nlywmwp3wpzcjxrgq9s9d2mmc6zg6xhsna00m663nkyc3n")))) (build-system go-build-system) (arguments - '(#:import-path "github.com/jmespath/go-jmespath")) + (list + #:go go-1.23 + #:import-path "github.com/jmespath/go-jmespath")) (native-inputs (list go-github-com-davecgh-go-spew go-github-com-pmezard-go-difflib @@ -5010,6 +5019,7 @@ controlled. It is based on netlink messages.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/json-iterator/go" #:test-flags ;; XXX: Try to skip just "Test_symmetric/map[test.stringKeyType]string". @@ -7086,6 +7096,7 @@ API.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/perimeterx/marshmallow")) (native-inputs (list go-github-com-go-test-deep)) @@ -7333,6 +7344,7 @@ part of @url{https://github.com/pion, Pion} WebRTC implementation.") (base32 "0f9jy80law69zb26rkb6kl6w1c66vdghdrmifhwlmzngb644ihdb")))) (arguments (list + #:go go-1.23 #:tests? #f ;Tests require network access. #:import-path "github.com/pion/ice/v3")) (propagated-inputs @@ -7638,6 +7650,7 @@ Protocol,SCTP} as specified in (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/pion/stun")) (native-inputs (list go-github-com-stretchr-testify)) @@ -7696,6 +7709,7 @@ Protocol,SCTP} as specified in (base32 "0yavl76y0fida9f1jfdmzdg7rm5jhp6kvdgn3smsf93jad1vbr2x")))) (arguments (list + #:go go-1.23 #:import-path "github.com/pion/stun/v3")) (propagated-inputs (list go-github-com-pion-dtls-v3 @@ -8332,6 +8346,7 @@ protocol.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/quic-go/webtransport-go" ;; Error: "68" is not greater than "80" #:test-flags #~(list "-skip" "TestDatagrams"))) @@ -9261,6 +9276,7 @@ encoding library for the MessagePack, CBOR, JSON and the Binc formats.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/urfave/negroni")) (home-page "https://github.com/urfave/negroni") (synopsis "Idiomatic HTTP Middleware for Golang") @@ -9724,6 +9740,7 @@ programming language.") (build-system go-build-system) (arguments (list + #:go go-1.23 ;; validation of time strings. only RFC3339 not all of ISO 8601 are ;; valid. expects: false, given true Schema: {"format":"time"} Data: ;; "01:01:01,1111" @@ -10236,6 +10253,7 @@ lists) (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "go.opencensus.io" #:test-flags #~(list "-skip" diff --git a/gnu/packages/golang-xyz.scm b/gnu/packages/golang-xyz.scm index be17fa1b39..989a90fc43 100644 --- a/gnu/packages/golang-xyz.scm +++ b/gnu/packages/golang-xyz.scm @@ -937,7 +937,9 @@ http://tartarus.org/~martin/PorterStemmer/index.html.") (build-system go-build-system) ;; TODO: Build cmd/chroma and cmd/chromad commands. (arguments - `(#:import-path "github.com/alecthomas/chroma")) + (list + #:go go-1.23 + #:import-path "github.com/alecthomas/chroma")) (native-inputs (list go-github-com-alecthomas-kong go-github-com-alecthomas-kong-hcl @@ -1356,6 +1358,7 @@ environment and runtime configuration.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/AndreasBriese/bbloom")) (home-page "https://github.com/AndreasBriese/bbloom") (synopsis "Bitset Bloom filter for Golang") @@ -1638,6 +1641,7 @@ cluster segmentation algorithm.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/arbovm/levenshtein")) (home-page "https://github.com/arbovm/levenshtein") (synopsis "Levenshtein Distance in Golang") @@ -1758,6 +1762,7 @@ for Go.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/asaskevich/govalidator" #:phases #~(modify-phases %standard-phases @@ -4059,6 +4064,7 @@ parse and compare two semantic version strings.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/coreos/go-systemd/v22" #:phases #~(modify-phases %standard-phases @@ -4408,6 +4414,8 @@ structs in the Go programming language.") (outputs '("out" "doc")) (arguments (list + ;; See <https://github.com/d5/tengo/issues/466>. + #:go go-1.23 #:import-path "github.com/d5/tengo/v2" #:phases #~(modify-phases %standard-phases @@ -6409,6 +6417,7 @@ library in go standard library.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/ghemawat/stream")) (home-page "https://github.com/ghemawat/stream") (synopsis "UNIX pipe-like chained filters") @@ -6556,6 +6565,7 @@ goroutines.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/go-errors/errors" ;; Stack trace does not contain source line: 'a: b(5)'. #:test-flags #~(list "-skip" "TestStackFormat"))) @@ -7127,6 +7137,7 @@ native Go structure.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/gobwas/glob")) (home-page "https://github.com/gobwas/glob") (synopsis "Go globbing library") @@ -7224,6 +7235,7 @@ size.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/godbus/dbus" #:phases #~(modify-phases %standard-phases @@ -7863,6 +7875,7 @@ provides a buffered io.Writer that is flushed at a timed interval.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/goverter/patherr")) (home-page "https://github.com/goverter/patherr") (synopsis "Implementation for Goverter's wrapErrorsUsing") @@ -9508,6 +9521,7 @@ object, which implements simple error-retrying functionality.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/jbenet/goprocess" #:test-flags #~(list "-short" @@ -9674,6 +9688,7 @@ text, etc. with a heavy emphasis on customization.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/jessevdk/go-flags" #:test-flags #~(list "-skip" "TestCompletion|TestParserCompletion"))) (propagated-inputs @@ -10158,6 +10173,7 @@ resources located relative to the executable file.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/karrick/godirwalk")) ;; To build all examples as a test scenario. (native-inputs @@ -11592,6 +11608,7 @@ implementing features like: (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/Masterminds/goutils")) (home-page "https://github.com/Masterminds/goutils/") (synopsis "Utility functions to manipulate strings") @@ -11851,14 +11868,16 @@ string.") "0l0l5s4hlsrm4z6hygig2pp1qirk5ycrzn9z27ay3yvg9k7zafzx")))) (build-system go-build-system) (arguments - `(#:import-path "github.com/mattn/go-shellwords" - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'patch-sh-path - (lambda* (#:key import-path #:allow-other-keys) - (substitute* (string-append - "src/" import-path "/util_posix.go") - (("/bin/sh") (which "sh")))))))) + (list + #:go go-1.23 + #:import-path "github.com/mattn/go-shellwords" + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-sh-path + (lambda* (#:key import-path #:allow-other-keys) + (substitute* (string-append + "src/" import-path "/util_posix.go") + (("/bin/sh") (which "sh")))))))) (home-page "https://github.com/mattn/go-shellwords") (synopsis "Parse lines into shell words") (description "This package parses text into shell arguments. Based on @@ -12404,6 +12423,7 @@ parsing.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/moby/sys/mountinfo" #:unpack-path "github.com/moby/sys" #:test-flags @@ -13356,6 +13376,7 @@ NSQ protocol @url{https://nsq.io/}.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/nxadm/tail")) (propagated-inputs (list go-github-com-fsnotify-fsnotify @@ -13931,6 +13952,7 @@ processes.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/pborman/getopt")) (home-page "https://github.com/pborman/getopt") (synopsis "Getopt style option parsing for Go") @@ -14002,7 +14024,9 @@ package (which is based off an earlier version of this package).") (base32 "1wypjrr1axkrkzp4n5gvams94f2sd7dq1pdpd2i35sgpdz6r2m6g")))) (build-system go-build-system) (arguments - (list #:import-path "github.com/pelletier/go-toml")) + (list + #:go go-1.23 + #:import-path "github.com/pelletier/go-toml")) (propagated-inputs (list go-github-com-burntsushi-toml go-github-com-davecgh-go-spew @@ -14262,6 +14286,7 @@ on top of the standard library @code{flag} package.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/pingcap/errors" #:test-flags #~(list "-skip" (string-join @@ -14326,6 +14351,7 @@ Pion}.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/pkg/diff")) (home-page "https://github.com/pkg/diff/") (synopsis "Create and print diffs") @@ -14415,6 +14441,7 @@ https://en.wikipedia.org/wiki/Extended_file_attributes}.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/pmezard/go-difflib/difflib" #:unpack-path "github.com/pmezard/go-difflib/")) (home-page "https://github.com/pmezard/go-difflib") @@ -14439,6 +14466,7 @@ https://en.wikipedia.org/wiki/Extended_file_attributes}.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/polydawn/refmt")) (propagated-inputs (list go-github-com-go-yaml-yaml @@ -14978,7 +15006,9 @@ logging.") (sha256 (base32 "0d1rg1drrfmabilqjjayklsz5d0n3hkf979sr3wsrw92bfbkivs7")))) (arguments - (list #:import-path "github.com/russross/blackfriday/v2")))) + (list + #:go go-1.23 + #:import-path "github.com/russross/blackfriday/v2")))) (define-public go-github-com-rwcarlsen-goexif ;; No release or version tag, Golang pseudo version: @@ -15741,6 +15771,7 @@ GNU/Linux, this is a proxy for the @command{xdg-open} command.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/smacker/go-tree-sitter")) (native-inputs (list go-github-com-stretchr-testify)) (home-page "https://github.com/smacker/go-tree-sitter") @@ -16188,6 +16219,7 @@ slices, JSON and other data.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/subosito/gotenv")) (native-inputs (list go-github-com-stretchr-testify)) @@ -17498,6 +17530,7 @@ Redis.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "github.com/warpfork/go-fsx")) (home-page "https://github.com/warpfork/go-fsx") (synopsis "Extended filesystem interface for Golang") @@ -18840,6 +18873,7 @@ written in YAML or JSON.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "go.mongodb.org/mongo-driver" #:test-flags #~(list "-skip" @@ -19281,6 +19315,7 @@ APIs may be unstable (build-system go-build-system) (arguments (list + #:go go-1.23 #:skip-build? #t #:import-path "go4.org" #:test-subdirs @@ -19942,6 +19977,7 @@ split out here for ease of reuse and maintainability.") (build-system go-build-system) (arguments (list + #:go go-1.23 #:import-path "k8s.io/klog/v2" #:test-flags #~(list "-skip"