oom pushed a commit to branch c++-team
in repository guix.

commit 2426d4a1fabbc38e3fd1b68ec492be31a83032a0
Author: Greg Hogan <c...@greghogan.com>
AuthorDate: Tue May 13 20:40:36 2025 +0000

    gnu: Remove BUILD_TESTING configuration flag.
    
    * gnu/packages/assembly.scm (cpu-features),
    * gnu/packages/astronomy.scm (casacore),
    * gnu/packages/audio.scm (csound),
    * gnu/packages/bioinformatics.scm (morpheus),
    * gnu/packages/code.scm (rtags),
    * gnu/packages/education.scm (gcompris-qt),
    * gnu/packages/game-development.scm (libccd),
    * gnu/packages/geo.scm (cloudcompare),
    * gnu/packages/glib.scm (dbus-cxx),
    * gnu/packages/graph.scm (faiss),
    * gnu/packages/graphics.scm (f3d, mmg),
    * gnu/packages/i2p.scm (i2pd),
    * gnu/packages/image-processing.scm (vtk),
    * gnu/packages/image.scm (openjpeg),
    * gnu/packages/irc.scm (quassel),
    * gnu/packages/jami.scm (jami),
    * gnu/packages/kde.scm (kapptemplate, kdeconnect, kdenlive, krita),
    * gnu/packages/kde-frameworks.scm (purpose, purpose-5),
    * gnu/packages/kde-office.scm (calligra, ghostwriter),
    * gnu/packages/linux.scm (bpftrace),
    * gnu/packages/maths.scm (blitz, double-conversion, hpcombi, lapack,
    vc),
    * gnu/packages/messaging.scm (libsignal-protocol-c),
    * gnu/packages/mold.scm (mold),
    * gnu/packages/music.scm (sonivox),
    * gnu/packages/networking.scm (dhtnet),
    * gnu/packages/opencl.scm (opencl-clhpp),
    * gnu/packages/openpgp.scm (rnp),
    * gnu/packages/photo.scm (darktable),
    * gnu/packages/popt.scm (gflags),
    * gnu/packages/rdesktop.scm (freerdp),
    * gnu/packages/security-token.scm (cppcodec),
    * gnu/packages/terminals.scm (libtsm),
    * gnu/packages/text-editors.scm (jucipp),
    * gnu/packages/xdisorg.scm (xsettingsd)
    [arguments]<#:configure-flags>: Remove BUILD_TESTING.
    
    * gnu/packages/jupyter.scm (xeus)
    [arguments]: Disable tests.
    <#:configure-flags>: Remove BUILD_TESTING.
    
    Change-Id: I6870720cdd2b10c7afacf0c6e7400cd1d73a1209
---
 gnu/packages/assembly.scm         |  5 ++---
 gnu/packages/astronomy.scm        |  1 -
 gnu/packages/audio.scm            |  3 +--
 gnu/packages/bioinformatics.scm   |  1 -
 gnu/packages/code.scm             |  3 +--
 gnu/packages/education.scm        |  3 +--
 gnu/packages/game-development.scm |  1 -
 gnu/packages/geo.scm              |  1 -
 gnu/packages/glib.scm             |  3 +--
 gnu/packages/graph.scm            |  3 +--
 gnu/packages/graphics.scm         |  2 --
 gnu/packages/i2p.scm              |  3 +--
 gnu/packages/image-processing.scm |  3 +--
 gnu/packages/image.scm            |  1 -
 gnu/packages/irc.scm              |  3 +--
 gnu/packages/jami.scm             |  1 -
 gnu/packages/jupyter.scm          |  6 +++---
 gnu/packages/kde-frameworks.scm   |  7 ++-----
 gnu/packages/kde-office.scm       |  5 +----
 gnu/packages/kde.scm              | 10 +++-------
 gnu/packages/linux.scm            |  1 -
 gnu/packages/maths.scm            | 14 ++++----------
 gnu/packages/messaging.scm        |  4 ++--
 gnu/packages/mold.scm             |  3 +--
 gnu/packages/music.scm            |  5 +----
 gnu/packages/networking.scm       |  3 +--
 gnu/packages/opencl.scm           |  3 +--
 gnu/packages/openpgp.scm          |  1 -
 gnu/packages/photo.scm            |  1 -
 gnu/packages/popt.scm             |  3 +--
 gnu/packages/rdesktop.scm         |  1 -
 gnu/packages/security-token.scm   |  2 --
 gnu/packages/terminals.scm        |  2 --
 gnu/packages/text-editors.scm     |  3 +--
 gnu/packages/xdisorg.scm          |  3 +--
 35 files changed, 32 insertions(+), 82 deletions(-)

diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index 0c6d6d668b..e893acc7f3 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -716,10 +716,9 @@ files.")
     (build-system cmake-build-system)
     (arguments
      (list
-      #:tests? #f
+      #:tests? #f ;; XXX: insists on using bundled googletest
       #:configure-flags
-      #~(list "-DBUILD_TESTING=off" ;; XXX: insists on using bundled googletest
-              "-DBUILD_SHARED_LIBS=ON"
+      #~(list "-DBUILD_SHARED_LIBS=ON"
               #$@(let ((target (%current-target-system)))
                    (if target
                        (cond ((string-prefix? "arm" target)
diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 34a08b8ea4..d605998c51 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -428,7 +428,6 @@ rendering of the atmosphere model and examine its 
properties.
       #:configure-flags
       #~(list "-DBUILD_PYTHON3=ON"
               "-DBUILD_PYTHON=OFF"
-              "-DBUILD_TESTING=TRUE"
               "-DUSE_HDF5=ON"
               "-DUSE_OPENMP=OFF"
               "-DUSE_THREADS=ON"
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index ec98780846..16c18bd8d7 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1997,8 +1997,7 @@ object library.")
         (base32 "1lgasyk8j4cl9178vci1dph63nks3cgwhf8y1d04z9dc8gg15dyn"))))
     (build-system cmake-build-system)
     (arguments
-     '(#:configure-flags '("-DBUILD_STATIC_LIBRARY=ON" ; required to build 
tests
-                           "-DBUILD_TESTING=ON")))
+     '(#:configure-flags '("-DBUILD_STATIC_LIBRARY=ON"))) ; required to build 
tests
     (native-inputs
      (list bison flex gettext-minimal zlib))
     (inputs
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 7b69b69101..55ed6dc1e1 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -11357,7 +11357,6 @@ seamless support for BCF and VCF files.")
      (list
       #:configure-flags
       '(list "-DMORPHEUS_GUI=OFF"
-             "-DBUILD_TESTING=ON"
              "-DDOWNLOAD_XTENSOR=OFF")
       #:phases
       '(modify-phases %standard-phases
diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 004f24de49..92b0481856 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -681,8 +681,7 @@ possible to collect coverage information without special 
compiler switches.")
     (arguments
      '(#:build-type "RelWithDebInfo"
        #:configure-flags
-       '("-DRTAGS_NO_ELISP_FILES=1"
-         "-DBUILD_TESTING=FALSE")
+       '("-DRTAGS_NO_ELISP_FILES=1")
        #:tests? #f))
     (native-inputs
      (list pkg-config))
diff --git a/gnu/packages/education.scm b/gnu/packages/education.scm
index 6b40b125df..489db4e3fb 100644
--- a/gnu/packages/education.scm
+++ b/gnu/packages/education.scm
@@ -240,8 +240,7 @@ of categories with some of the activities available in that 
category.
                    (setenv "DISPLAY" ":1")
                    ;; The test suite wants to write to /homeless-shelter
                    (setenv "HOME" (getcwd)))))
-           #:configure-flags #~(list "-DQML_BOX2D_MODULE=disabled"
-                                     "-DBUILD_TESTING=TRUE")))
+           #:configure-flags #~(list "-DQML_BOX2D_MODULE=disabled")))
     (native-inputs
      (list extra-cmake-modules
            gettext-minimal
diff --git a/gnu/packages/game-development.scm 
b/gnu/packages/game-development.scm
index f0f2eb0c2d..c710ea2360 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -3147,7 +3147,6 @@ is designed to be used in interactive 3D graphics 
applications.")
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags '("-DBUILD_DOCUMENTATION=ON"
-                           "-DBUILD_TESTING=ON"
                            "-DENABLE_DOUBLE_PRECISION=ON")))
     (native-inputs
      (list python-sphinx))
diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index cb59a231af..66e698c8cf 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -4202,7 +4202,6 @@ and 2D images (photos taken using a 3D imaging system).")
       #:configure-flags #~(list
                            ;; Options
                            "-DOPTION_BUILD_CCVIEWER=NO"
-                           "-DBUILD_TESTING=ON"
                            "-DOPTION_USE_SHAPE_LIB=YES"
                            "-DOPTION_USE_DXF_LIB=YES"
                            "-DOPTION_USE_GDAL=YES"
diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index 3e19a2398e..b59ad18f08 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -1264,8 +1264,7 @@ programming language.  It also provides the 
@command{dbusxx-xml2cpp} and
               (snippet '(delete-file-recursively "tools/libcppgenerate"))))
     (build-system cmake-build-system)
     (arguments
-     (list #:configure-flags #~(list "-DBUILD_TESTING=ON"
-                                     "-DENABLE_TOOLS=ON"
+     (list #:configure-flags #~(list "-DENABLE_TOOLS=ON"
                                      "-DENABLE_GLIB_SUPPORT=ON"
                                      "-DTOOLS_BUNDLED_CPPGENERATE=OFF")
            ;; There is no /etc/machine-id file in the build environment.
diff --git a/gnu/packages/graph.scm b/gnu/packages/graph.scm
index b8203db3d8..8c3159855f 100644
--- a/gnu/packages/graph.scm
+++ b/gnu/packages/graph.scm
@@ -592,8 +592,7 @@ graphs.")
     (arguments
      (list #:configure-flags
            #~'("-DFAISS_ENABLE_GPU=OFF"     ; thanks, but no thanks, CUDA.
-               "-DFAISS_ENABLE_PYTHON=OFF"
-               "-DBUILD_TESTING=ON")))
+               "-DFAISS_ENABLE_PYTHON=OFF")))
     (inputs
      (list openblas))
     (native-inputs
diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 62eddc4d65..1ead310c51 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -2858,7 +2858,6 @@ generated discrete signed distance field using the cubic 
spline kernel.
                    (string-append "-DCMAKE_INSTALL_MANDIR=" #$output 
"/share/man")
                    "-DBUILD_SHARED_LIBS=ON"
                    "-DBUILD_DOC=ON"
-                   "-DBUILD_TESTING=ON"
                    ;; The longer tests are for continuous integration and
                    ;; depend on input data which must be downloaded.
                    "-DONLY_VERY_SHORT_TESTS=ON"
@@ -3084,7 +3083,6 @@ desired local properties.")
       #:configure-flags
       #~(list (string-append "-DCMAKE_INSTALL_DOCDIR=" #$output
                              "/share/doc/" #$name "-" #$version)
-              "-DBUILD_TESTING=OFF"
               "-DF3D_LINUX_GENERATE_MAN=ON"
               "-DF3D_USE_EXTERNAL_CXXOPTS=ON"
               "-DF3D_USE_EXTERNAL_NLOHMANN_JSON=ON"
diff --git a/gnu/packages/i2p.scm b/gnu/packages/i2p.scm
index b4f0c8d639..bb5fa5fce8 100644
--- a/gnu/packages/i2p.scm
+++ b/gnu/packages/i2p.scm
@@ -54,8 +54,7 @@
       #:configure-flags
       #~(list (string-append "-S" #$source "/build")
               "-DWITH_UPNP=ON"
-              "-DBUILD_SHARED_LIBS=ON"
-              "-DBUILD_TESTING=ON")))
+              "-DBUILD_SHARED_LIBS=ON")))
     (home-page "https://i2pd.website/";)
     (synopsis "Router for an end-to-end encrypted and anonymous internet")
     (description "i2pd is a client for the anonymous I2P network, upon which
diff --git a/gnu/packages/image-processing.scm 
b/gnu/packages/image-processing.scm
index 964676bee3..1634587c90 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -297,8 +297,7 @@ many popular formats.")
     (arguments
      (list #:build-type "Release"           ;Build without '-g' to save space.
            #:configure-flags
-           #~'( ;;"-DBUILD_TESTING:BOOL=TRUE"  ;not honored
-               "-DVTK_USE_EXTERNAL=OFF"           ;default
+           #~'("-DVTK_USE_EXTERNAL=OFF"           ;default
                "-DVTK_MODULE_USE_EXTERNAL_VTK_doubleconversion=ON"
                "-DVTK_MODULE_USE_EXTERNAL_VTK_eigen=ON"
                "-DVTK_MODULE_USE_EXTERNAL_VTK_expat=ON"
diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 3a26cd2cff..0af7680b3f 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1022,7 +1022,6 @@ test suite, including conformance tests (following Rec. 
ITU-T T.803 | ISO/IEC
        (list
         "-DBUILD_STATIC_LIBS=OFF"
         "-DBUILD_UNIT_TESTS=ON"
-        "-DBUILD_TESTING=ON"
         (string-append "-DOPJ_DATA_ROOT="
                        (assoc-ref %build-inputs "openjpeg-data")))
        #:phases
diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm
index 2ab2443356..5ae0cce156 100644
--- a/gnu/packages/irc.scm
+++ b/gnu/packages/irc.scm
@@ -291,8 +291,7 @@ setting @env{LUA_PATH} and @env{LUA_CPATH} in glirc's 
run-time environment.")
     (arguments
       ;; The three binaries are not mutually exlusive, and are all built
       ;; by default.
-     '(#:configure-flags '("-DBUILD_TESTING=ON"
-                           ;;"-DWANT_QTCLIENT=OFF"
+     '(#:configure-flags '(;;"-DWANT_QTCLIENT=OFF"
                            ;;"-DWANT_CORE=OFF"
                            ;;"-DWANT_MONO=OFF"
                            "-DWITH_KDE=OFF"
diff --git a/gnu/packages/jami.scm b/gnu/packages/jami.scm
index db45c9973e..f647c5dbe8 100644
--- a/gnu/packages/jami.scm
+++ b/gnu/packages/jami.scm
@@ -305,7 +305,6 @@ QSortFilterProxyModel conveniently exposed for QML.")
       #:qtbase qtbase
       #:configure-flags
       #~(list "-DWITH_DAEMON_SUBMODULE=OFF"
-              "-DBUILD_TESTING=ON"
               ;; Disable the webengine since it grows the closure size by
               ;; about 450 MiB and requires more resources.
               "-DWITH_WEBENGINE=OFF"
diff --git a/gnu/packages/jupyter.scm b/gnu/packages/jupyter.scm
index 5450a4fd9a..975366598f 100644
--- a/gnu/packages/jupyter.scm
+++ b/gnu/packages/jupyter.scm
@@ -515,9 +515,9 @@ extensions.")
               (file-name (git-file-name name version))))
     (build-system cmake-build-system)
     (arguments
-     '(#:configure-flags '("-DBUILD_STATIC_LIBS=OFF"
-                           "-DDISABLE_ARCH_NATIVE=ON" ;no '-march=native'
-                           "-DBUILD_TESTING=ON")))
+     '(#:tests? #f
+       #:configure-flags '("-DBUILD_STATIC_LIBS=OFF"
+                           "-DDISABLE_ARCH_NATIVE=ON"))) ;no '-march=native'
     (native-inputs
      (list pkg-config
            ;; The following inputs are used by the test suite.
diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index cf1ec06bce..865d87e808 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -5220,8 +5220,7 @@ script engines.")
       qtdeclarative
       prison))
     (arguments
-     (list #:tests? #f ;; seem to require network; don't find QTQuick 
components
-           #:configure-flags #~'("-DBUILD_TESTING=OFF"))) ; not run anyway
+     (list #:tests? #f)) ;; seem to require network; don't find QTQuick 
components
     (home-page "https://community.kde.org/Frameworks";)
     (synopsis "Offers available actions for a specific purpose")
     (description "This framework offers the possibility to create integrate
@@ -5259,9 +5258,7 @@ need.")
       qtbase-5
       qtdeclarative-5))
     (arguments
-     (list #:tests? #f ;; seem to require network; don't find QTQuick 
components
-           ;; not run anyway
-           #:configure-flags #~'("-DBUILD_TESTING=OFF")))))
+     (list #:tests? #f)))) ;; seem to require network; don't find QTQuick 
components
 
 (define-public ktextaddons
   (package
diff --git a/gnu/packages/kde-office.scm b/gnu/packages/kde-office.scm
index d21c276177..604b2d17d9 100644
--- a/gnu/packages/kde-office.scm
+++ b/gnu/packages/kde-office.scm
@@ -67,8 +67,6 @@
     (arguments
      (list #:qtbase qtbase
            ;; XXX: 26/164 tests fail.
-           #:configure-flags
-           #~(list "-DBUILD_TESTING=OFF")
            #:tests? #f))
     (native-inputs
      (list extra-cmake-modules kdoctools perl pkg-config))
@@ -166,8 +164,7 @@ Advanced plugins:
     (arguments
      (list #:qtbase qtbase
            #:configure-flags
-           #~(list "-DQT_MAJOR_VERSION=6"
-                   "-DBUILD_TESTING=ON")))
+           #~(list "-DQT_MAJOR_VERSION=6")))
     (native-inputs
      (list extra-cmake-modules kdoctools pkg-config qttools))
     (inputs
diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 7637ffd69c..f6431e9056 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -390,7 +390,6 @@ annotating features.")
      ;; that individual tests can't be skipped.
      (list
       #:qtbase qtbase
-      #:configure-flags #~(list "-DBUILD_TESTING=off")
       #:tests? #f
       #:phases
       #~(modify-phases %standard-phases
@@ -543,9 +542,7 @@ such as addition, trigonometric functions or derivatives.")
         (base32 "0mgpk6879dprhpxmbdgbb6sz3ik9ycav4sihh20qmsgj09h8qp3g"))))
     (build-system qt-build-system)
     (arguments
-     (list #:qtbase qtbase
-           #:configure-flags
-           #~(list "-DBUILD_TESTING=ON")))
+     (list #:qtbase qtbase))
     (native-inputs
      (list extra-cmake-modules kdoctools))
     (inputs
@@ -981,7 +978,7 @@ painting, image manipulating and icon editing.")
     (build-system qt-build-system)
     (arguments
      `(#:tests? #f
-       #:configure-flags (list "-DBUILD_TESTING=OFF -DCMAKE_CXX_FLAGS=-fPIC")
+       #:configure-flags (list "-DCMAKE_CXX_FLAGS=-fPIC")
        #:phases (modify-phases %standard-phases
                   (add-after 'unpack 'patch-raqm
                     (lambda _
@@ -1634,8 +1631,7 @@ different notification systems.")
     (arguments
      (list #:qtbase qtbase
            #:configure-flags
-           #~(list "-DBUILD_TESTING=ON"
-                   (string-append "-DQtWaylandScanner_EXECUTABLE="
+           #~(list (string-append "-DQtWaylandScanner_EXECUTABLE="
                                   #$(this-package-native-input "qtwayland")
                                   "/lib/qt6/libexec/qtwaylandscanner")
                    "-DKDE_INSTALL_LIBEXECDIR=libexec"
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 01c11b183c..85a641dc25 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -10825,7 +10825,6 @@ modification of BPF objects on the system.")
     (arguments
      (list
       #:test-exclude "(runtime_tests|tools-parsing-test)"
-      #:configure-flags #~(list "-DBUILD_TESTING=ON")
       #:phases
       #~(modify-phases %standard-phases
           ;; This patch also fixes broken compilation due to improper detection
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 0c2a0c9d54..e33caff858 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -478,8 +478,7 @@ enough to be used effectively as a scientific calculator.")
                 "0csy4pjw1p8rp6g5qxi2h0ychhhp1fldv7gb761627fs2mclw9gv"))))
     (build-system cmake-build-system)
     (arguments
-     '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON"
-                           "-DBUILD_TESTING=ON")))
+     '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
     (synopsis "Conversion routines for IEEE doubles")
     (description
      "The double-conversion library provides binary-decimal and decimal-binary
@@ -1192,8 +1191,7 @@ large scale eigenvalue problems.")
                           "-DCBLAS=ON"
                           "-DLAPACKE=ON"
                           ;; Build the 'LAPACKE_clatms' functions.
-                          "-DLAPACKE_WITH_TMG=ON"
-                          "-DBUILD_TESTING=ON")))
+                          "-DLAPACKE_WITH_TMG=ON")))
     (synopsis "Library for numerical linear algebra")
     (description
      "LAPACK is a Fortran 90 library for solving the most commonly occurring
@@ -3122,8 +3120,6 @@ includes a complete LAPACK implementation.")
               (sha256
                (base32
                 "00mbxw5x6m61n0x68dsiyq97i7b08h3hkbj9is2w6gcg571jy319"))))
-    (arguments
-     (list #:configure-flags #~(list "-DBUILD_TESTING=ON")))
     (native-inputs
      (list catch2-3))
     (build-system cmake-build-system)
@@ -7927,8 +7923,7 @@ supports compressed MAT files, as well as newer (version 
7.3) MAT files.")
     (arguments
      (list
       #:configure-flags
-      #~(list "-DBUILD_TESTING=ON"
-              ;; By default, Vc will optimize for the CPU of the build machine.
+      #~(list ;; By default, Vc will optimize for the CPU of the build machine.
               ;; Setting this to "none" makes it create portable binaries.  See
               ;; "cmake/OptimizeForArchitecture.cmake".
               "-DTARGET_ARCHITECTURE=none")
@@ -10419,8 +10414,7 @@ projects up to the certification of critical software.")
     (build-system cmake-build-system)
     (arguments
      (list
-      #:configure-flags #~(list "-DBUILD_DOC=ON"
-                                "-DBUILD_TESTING=ON")
+      #:configure-flags #~(list "-DBUILD_DOC=ON")
       #:modules '((guix build cmake-build-system)
                   ((guix build gnu-build-system) #:prefix gnu:)
                   (guix build utils))
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index ceb231c6de..3f6320c7a4 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -567,8 +567,8 @@ your private keys, no previous conversation is 
compromised.")
              (base32
               "0z5p03vk15i6h870azfjgyfgxhv31q2vq6rfhnybrnkxq2wqzwhk"))))
    (arguments
-    `(;; Required for proper linking and for tests to run.
-      #:configure-flags '("-DBUILD_SHARED_LIBS=on" "-DBUILD_TESTING=1")))
+    `(;; Required for proper linking.
+      #:configure-flags '("-DBUILD_SHARED_LIBS=on")))
    (build-system cmake-build-system)
    (inputs (list ;; Required for tests:
                  check openssl))
diff --git a/gnu/packages/mold.scm b/gnu/packages/mold.scm
index 1f072197f6..2b46611a09 100644
--- a/gnu/packages/mold.scm
+++ b/gnu/packages/mold.scm
@@ -61,8 +61,7 @@
       #:configure-flags #~(list #$@(if (target-64bit?)
                                        '("-DMOLD_USE_SYSTEM_MIMALLOC=ON")
                                        '("-DMOLD_USE_MIMALLOC=OFF"))
-                                "-DMOLD_USE_SYSTEM_TBB=ON"
-                                "-DBUILD_TESTING=ON")
+                                "-DMOLD_USE_SYSTEM_TBB=ON")
       #:phases
       #~(modify-phases %standard-phases
           (add-before 'configure 'force-system-xxhash
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ea6698fda4..3b6f5fa8d1 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5974,10 +5974,7 @@ the electronic or dubstep genre.")
                 "0zn9v4lxjpnpdlpnv2px8ch3z0xagmqlvff5pd39pss3mxfp32g0"))))
     (build-system cmake-build-system)
     (arguments
-     (list #:configure-flags
-           (if (%current-target-system)
-               #~(list "-DBUILD_TESTING=OFF")
-               #~(list "-DBUILD_TESTING=ON"))))
+     (list #:tests? (not (%current-target-system)))) ; run unless 
cross-compiling
     (native-inputs
      (list googletest))
     (home-page "https://github.com/pedrolcl/sonivox";)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index e45fbdc367..867f7902db 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -4087,8 +4087,7 @@ A very simple IM client working over the DHT.
       (arguments
        (list
         #:configure-flags #~(list "-DBUILD_DEPENDENCIES=OFF"
-                                  "-DBUILD_SHARED_LIBS=ON"
-                                  "-DBUILD_TESTING=ON")
+                                  "-DBUILD_SHARED_LIBS=ON")
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'delete-problematic-tests
diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 11a2c43b63..3a1c167952 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -116,8 +116,7 @@
     (propagated-inputs
      (list opencl-headers))
     (arguments
-     `(#:configure-flags (list "-DBUILD_EXAMPLES=OFF" "-DBUILD_TESTS=OFF"
-                               "-DBUILD_TESTING=OFF") ;; CTest needs this to 
be turned off
+     `(#:configure-flags (list "-DBUILD_EXAMPLES=OFF" "-DBUILD_TESTS=OFF")
        ;; The regression tests require a lot more dependencies.
        #:tests? #f))
     (build-system cmake-build-system)
diff --git a/gnu/packages/openpgp.scm b/gnu/packages/openpgp.scm
index c98023566f..1aebfa6a68 100644
--- a/gnu/packages/openpgp.scm
+++ b/gnu/packages/openpgp.scm
@@ -121,7 +121,6 @@ environments.")
                 ;; Lower the minimum tuning ratio from 6 to 4, as suggested
                 ;; upstream to avoid the s2k_iteration_tuning failing.
                 "-DS2K_MINIMUM_TUNING_RATIO=4"
-                "-DBUILD_TESTING=on"
                 "-DDOWNLOAD_GTEST=off"
                 "-DDOWNLOAD_RUBYRNP=off")
         #:phases
diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index 49bb2ed713..6c14e19076 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -548,7 +548,6 @@ photographic equipment.")
      (list
       #:configure-flags
       #~(list "-DBINARY_PACKAGE_BUILD=On"
-              "-DBUILD_TESTING=On"
               "-DDONT_USE_INTERNAL_LIBRAW=On")
       #:phases
       #~(modify-phases %standard-phases
diff --git a/gnu/packages/popt.scm b/gnu/packages/popt.scm
index 4e3baee408..05a7372554 100644
--- a/gnu/packages/popt.scm
+++ b/gnu/packages/popt.scm
@@ -110,8 +110,7 @@ similar to getopt(3), it contains a number of enhancements, 
including:
        (file-name (git-file-name name version))))
     (build-system cmake-build-system)
     (arguments
-     '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON"
-                           "-DBUILD_TESTING=ON")))
+     '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
     (home-page "https://gflags.github.io/gflags/";)
     (synopsis "C++ library for command-line argument parsing")
     (description
diff --git a/gnu/packages/rdesktop.scm b/gnu/packages/rdesktop.scm
index 7eabfcbb0a..11737d0d1f 100644
--- a/gnu/packages/rdesktop.scm
+++ b/gnu/packages/rdesktop.scm
@@ -153,7 +153,6 @@ to remotely control a user's Windows desktop.")
                           #~())
                    "-DWITH_PULSE=ON"
                    "-DWITH_CUPS=ON"
-                   "-DBUILD_TESTING=ON"
                    "-DWITH_SERVER=ON" ;build servers
                    "-DWITH_SHADOW=ON" ;build shadow server
                    "-DWITH_PROXY=ON")))
diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 1d4a0360e7..ec245d6ca0 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -896,8 +896,6 @@ to the @code{python-yubikey-manager} package.")
                (base32
                 "0z39f8w0zvra874az0f67ck1al9kbpaidpilggbl8jnfs05010ck"))))
     (build-system cmake-build-system)
-    (arguments
-     '(#:configure-flags (list "-DBUILD_TESTING=on")))
     (native-inputs (list pkg-config qttools-5))
     (inputs (list catch2))
     (home-page "https://github.com/tplgy/cppcodec";)
diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 0cf8ffdd12..64c87dd481 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -290,8 +290,6 @@ text-based approach to terminal recording.")
              (delete-file-recursively "external/xkbcommon")
              #t))))
       (build-system cmake-build-system)
-      (arguments
-       `(#:configure-flags '("-DBUILD_TESTING=ON")))
       (native-inputs
        (list check libxkbcommon ; for xkbcommon-keysyms.h
              pkg-config))
diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 1df4daafc1..731bdc2939 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -764,8 +764,7 @@ jmacs, joe, jpico, jstar, and rjoe.")
                   (delete-file-recursively "lib/json")))))
     (build-system cmake-build-system)
     (arguments
-     (list #:configure-flags #~(list "-DBUILD_TESTING=ON")
-           #:phases
+     (list #:phases
            #~(modify-phases %standard-phases
                (add-after 'unpack 'patch-tiny-process-library
                  (lambda* (#:key native-inputs inputs #:allow-other-keys)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 28d6786069..6b369a42fa 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -3316,8 +3316,7 @@ virtual-pointer (pointer command) protocols.")
         (base32 "14gnkz18dipsa2v24f4nm9syxaa7g21iqjm7y65jn849ka2jr1h8"))))
     (build-system cmake-build-system)
     (arguments
-     (list #:configure-flags #~(list "-DBUILD_TESTING=ON")
-           #:phases #~(modify-phases %standard-phases
+     (list #:phases #~(modify-phases %standard-phases
                         (add-after 'unpack 'disable-problematic-tests
                           (lambda _
                             (substitute* "config_parser_test.cc"

Reply via email to