Eli Zaretskii <e...@gnu.org> skribis:
> First, running the test suite resulted in some failures.
> test-system-cmds failed because it uses '..' quoting on the command
> line, which the Windows shell doesn't support. Fixed thusly:
>
> --- test-suite/standalone/test-system-cmds~0 2010-12-08 11:07:11.000000000
> +0200
> +++ test-suite/standalone/test-system-cmds 2013-06-12 13:52:14.333269200
> +0300
> @@ -10,7 +10,7 @@
> "test-system-cmds: (system) did not return a boolean\n")
> (exit 1)))
>
> - (let ((rs (status:exit-val (system "guile -c '(exit 42)'"))))
> + (let ((rs (status:exit-val (system "guile -c \"(exit 42)\""))))
> (if (not (= 42 rs))
> (begin
> (simple-format
> @@ -39,4 +39,4 @@
>
> ;; Local Variables:
> ;; mode: scheme
> -;; End:
> \ No newline at end of file
> +;; End:
Applied.
> '/tmp' will exist, none of which can be counted upon on Windows.
> Here's the fix for that (the declaration of mkstemp avoids compiler
> warning):
>
> --- test-suite/standalone/test-unwind.c~0 2012-01-31 00:32:38.000000000
> +0200
> +++ test-suite/standalone/test-unwind.c 2013-06-12 14:11:47.967231800
> +0300
> @@ -200,9 +200,19 @@ check_ports ()
> #define FILENAME_TEMPLATE "/check-ports.XXXXXX"
> char *filename;
> const char *tmpdir = getenv ("TMPDIR");
> +#ifdef __MINGW32__
> + extern int mkstemp (char *);
>
> if (tmpdir == NULL)
> + tmpdir = getenv ("TEMP");
> + if (tmpdir == NULL)
> + tmpdir = getenv ("TMP");
> + if (tmpdir == NULL)
> + tmpdir = "/";
> +#else
> + if (tmpdir == NULL)
> tmpdir = "/tmp";
> +#endif
>
> filename = alloca (strlen (tmpdir) + sizeof (FILENAME_TEMPLATE) + 1);
> strcpy (filename, tmpdir);
Applied, thanks.
In the future, could you send patches as produced by ‘git format-patch’,
with a ChangeLog-style commit log? That would allow us to preserve
authorship, and make it easier to apply patches.
Ludo’.
