On May 22, 2012, at 03:54, Andy Wingo wrote: > On Mon 21 May 2012 07:45, Ken Raeburn <[email protected]> writes: > >> I've also checked in on master a couple pretty straightforward-looking >> fixes. I don't know if either would be applicable to the current >> release. > > Thank you very much for these, especially the locking one! How did you > catch the locking bug, just by code inspection? It could be at the root > of a tricky bug that has been following me around since that code was > introduced…
No, I found the struct-size one by inspection, and ran into the locking one trying to test it. :-) The build hung with consistent stack traces while running Guile, always trying to lock that mutex. I suspected a double-lock attempt or a missing unlock, so I instrumented the lock functions to report what they were doing, with line numbers, and noticed the excess unlocks. > Thankfully those bugs do not apply to the stable branch. That's good news. Ken
