Hi Noah, Just a few superficial stylistic comments until I have something more clever to say: ;-)
"Noah Lavine" <nlav...@haverford.edu> skribis: > (define default-environment > - `( (cons . ,(value-set-with-values 'cons)) > - (car . ,(value-set-with-values 'car)) > - (cdr . ,(value-set-with-values 'cdr)) > + `( (cons . ,(value-set-with-values prim-cons)) > + (car . ,(value-set-with-values prim-car )) > + (cdr . ,(value-set-with-values prim-cdr )) > )) Please avoid trailing closing parenthesis. Also, what about “vset” or just “set” instead of “value-set”? > + (set! (a-verify-exps ret) > + (map (lambda (x) (rec ret x env)) args)) > + ret)) Please privilege a functional style, as much as possible (in some cases we lack the tools to do better, so that’s fine.) > +(pass-if "value-set-can-be-anything?" > + (value-set-can-be-anything? anything)) In Emacs you can (put 'pass-if 'scheme-indent-function 1) to get the “right” indentation. Thanks, Ludo’.
