Neil Jerram escreveu: > Since you mention 'cleanups', I must say that I agree with Ludovic, > that it would have been preferable to post the patch for > review/discussion before committing it, since that is our (majority) > current practice. Sure there may have been a few exceptions, but only > for trivial changes, I believe, and I don't believe that this was - > overall - a trivial change. (I'm aware that it has lots of trivial > bits in it, but I don't think it's all trivial.) > > (I also think it's arguable that actually committing to a branch is > more convenient, for author and reviewers, than juggling emails - but > that then leads on to other questions, like what expectations people > can have of the "master" branch, and why we are using Git like CVS...)
If we want to code review as a policy, I'm fine with that, but let's do it in a structured way then. Guido van Rossum wrote a webtool for code review, which should be fairly easy to use and setup http://code.google.com/appengine/articles/rietveld.html and I heard people have recently added Git support to it. How about using this for Guile? (We need to figure out how to set it up, and contributors need to have gmail addresses, but that should not be a problem, is it?) -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen
