Ludovic Courtès escreveu: > Hello, > > Han-Wen Nienhuys <[EMAIL PROTECTED]> writes: > >> Ludovic Courtès escreveu: > >>> Off the top of my head: incorrect indentation, missing spaces around >>> brackets, and more importantly comments (see (standards.info)Comments). >> The code I went through should not have that; please point me to locations >> where things are broken so I can fix them. > > E.g., from commit: > > +/* > + Classic MIT Hack, see e.g. http://www.tekpool.com/?cat=9 > + */ > +int scm_i_uint_bit_count(unsigned int u) > > (BTW, it'd make sense to use Gnulib's `count-one-bits' module, which is > able to use GCC's `__builtin_popcount ()'.) > > +/* > + Amount of cells marked in this cell, measured in 1-cells. > + */ > +int > +scm_i_card_marked_count (scm_t_cell *card, int span) > > + while (bvec < bvec_end) { > + count += scm_i_uint_bit_count(*bvec); > + bvec ++; > + }
Yes, sorry about that. Being at google means that the google style is now native to me. -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen
