Carl Worth wrote: > On Wed, 05 Dec 2007 11:09:33 +0100, Denis Oliver Kropp wrote: >> CAIRO-DIRECTFB: Use DirectFB for show_glyphs() even if it is unaccelerated. >> >> The software fallback in DirectFB is well optimized. > > Hi Denis, > > I'm inclined to let anyone who wants to maintain > cairo-directfb-surface.c do whatever they feel is best to it. But > could you please send proposed patches to the cairo mailing list? > There are probably cairo-directfb maintainers there that will want to > review this. > >> -#if DFB_SHOW_GLYPHS >> +#if DFB_SHOW_GLYPHS && 0 >> if (!(dsc.acceleration_mask & DFXL_BLIT) || >> !(dsc.blitting_flags & DSBLIT_COLORIZE) || >> !(dsc.blitting_flags & DSBLIT_BLEND_ALPHACHANNEL)) > > Why leave this code around? If it's truly not wanted, it would be > cleaner to remove it.
Yes, usually I'm against commented out or disabled code being checked in, except for active construction sites. Feel free to remove it :) -- Best regards, Denis Oliver Kropp .------------------------------------------. | DirectFB - Hardware accelerated graphics | | http://www.directfb.org/ | "------------------------------------------" _______________________________________________ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list
