Hi Daniel, On Wed, 10 Dec 2025 13:27:05 -0500 Daniel Murcia <[email protected]> wrote:
> Hi Grub community! > I am a frequent user of the grub software; I have configured my bootloader > with some nice custom themes, however I encounter a problem trying to align > some items... > > In the problematic theme, there is a custom selected_item_pixmap_style that > is overlapping the icons. > I tried various configuration options, but none of them seems to separate > the icon from the selected-background. > This is an image of the problem. > [image: image.png] > The selected_background (the vertical bar) overlaps (touches) some icons. > > I was able to create 2 workarounds: > 1. modify the icon images to create an artificial icon offset > 2. implement a new icon_offset configuration option into grub > > The first approach was a temporal solution, but now that I was able to > implement a real icon offset into grub, I wonder how I can push that > contribution to the upstream project? Well you're in the right place. Just send your patches to this list using git send-email (should probably use git format-patch to create the patch series to send). Make sure that your patches are based off the latest master. Also CC Daniel Kiper <[email protected]>. Then ideally, someone will review the patches and give feedback for modifications and you'll send a v2 or it'll be accepted as is. > Is there a test/lint/CI-pipeline that I should execute before? Not right now. You can run "make check-nonnative" and see what fails and there will be at least one failure. And report back to the list. However, as I'm not aware of any tests that cover the area you're modifying, I doubt the tests would catch anything. Glenn > FYI: As you can see on the example image, I am a user of NixOS and the way > I am testing this new feature is by patching the src of grub itself, and > using this modified grub in my machine. _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
