On Mon, 17 Nov 2025 18:29:31 +0100 Daniel Kiper <[email protected]> wrote:
> On Tue, Nov 11, 2025 at 01:13:28AM -0600, Glenn Washburn wrote: > > Remove unnecessary subshells. Loop over autogenerated po files only once. > > Use existing LINGUAS created by bootstrap instead of finding po files > > again. > > > > Signed-off-by: Glenn Washburn <[email protected]> > > --- > > bootstrap.conf | 19 +++++++------------ > > 1 file changed, 7 insertions(+), 12 deletions(-) > > > > diff --git a/bootstrap.conf b/bootstrap.conf > > index 79d4248c84aa..7104692d43ea 100644 > > --- a/bootstrap.conf > > +++ b/bootstrap.conf > > @@ -113,17 +113,12 @@ bootstrap_epilogue () { > > # languages. > > autogenerated="en@quot en@hebrew de@hebrew en@cyrillic en@greek > > en@arabic en@piglatin de_CH" > > > > - for x in $autogenerated; do > > - rm -f "po/$x.po"; > > - done > > - > > - ( > > - ( > > - cd po && ls *.po| cut -d. -f1 > > - for x in $autogenerated; do > > - echo "$x"; > > - done > > - ) | sort | uniq | xargs > > - ) >po/LINGUAS > > + { > > + ls po/*.po | xargs -L 100 basename -s .po -a > > I suggest to add "-r" option to the xargs command. Yes, good catch. > > > + for x in $autogenerated; do > > + rm -f "po/$x.po" > > + echo "$x" > > + done > > + } | sort | uniq | xargs >po/LINGUAS > > Ditto... Here I don't think it matters. There is no command, so no command is run regardless if there's input or not. We don't have the problem of the usage above (namely running the command with no arguments). It should be said that this usage is unmodified from linguas.sh. It appears that the only reason xargs is used here is to convert newlines to spaces, which could be more explicitly done by using "tr '\n' ' '". Since it was a strange usage and wasn't 100% sure if there were other reasons it was used, I left it as is. So I think we should leave as is or convert to tr. I'll leave as is for now, unless you're adamant about adding -r. Glenn > > If you fix these minor issues you can add my RB to all patches... > > Daniel _______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
