On Fri, Sep 26, 2025 at 9:58 AM Vladimir 'phcoder' Serbinenko < [email protected]> wrote:
> > > Le jeu. 25 sept. 2025, 21:04, Leo Sandoval <[email protected]> a écrit : > >> >> >> On Wed, Sep 24, 2025 at 1:55 PM Vladimir 'phcoder' Serbinenko < >> [email protected]> wrote: >> >>> What is the influence on core.img size on i386-pc? Are we still within >>> our promises for supporting 31K gaps with simple config? >>> >> >> running this in both grub versions >> >> $ grub2-mkimage -O i386-pc -p /tmp -o core.img biosdisk part_msdos ext2 >> >> core.img file increases from 34538 to 35132 bytes, so the increase is >> about 0.6K. >> > > 0.6K out of 31K is a lot. Is there a way to decrease this overhead? > I forgot to indicate that this increase includes this patch and the other in the series, which includes the function name also. In general, this 0.6K increase includes the file:function:line_number on the logs. No idea how to decrease it. Any suggestion to try? > > >>>> extern grub_err_t EXPORT_VAR(grub_errno); >>>> extern char EXPORT_VAR(grub_errmsg)[GRUB_MAX_ERRMSG]; >>>> >>>> -grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *fmt, ...) >>>> - __attribute__ ((format (GNU_PRINTF, 2, 3))); >>>> +grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *file, >>>> const int line, const char *fmt, ...) >>>> + __attribute__ ((format (GNU_PRINTF, 4, 5))); >>>> + >>>> +#define grub_error(n, fmt, ...) grub_error (n, __FILE__, __LINE__, >>>> fmt, ##__VA_ARGS__) >>>> + >>>> + >>>> void EXPORT_FUNC(grub_fatal) (const char *fmt, ...) __attribute__ >>>> ((noreturn)); >>>> void EXPORT_FUNC(grub_error_push) (void); >>>> int EXPORT_FUNC(grub_error_pop) (void); >>>> -- >>>> 2.50.1 >>>> >>>> >>>> _______________________________________________ >>>> Grub-devel mailing list >>>> [email protected] >>>> https://lists.gnu.org/mailman/listinfo/grub-devel >>>> >>>
_______________________________________________ Grub-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/grub-devel
