On Fri, Jul 25, 2025 at 7:43 AM Daniel Kiper <dki...@net-space.pl> wrote:
>
> Hey,
>
> I will review this patch set when you CC Xen-devel ML. I have asked
> about this last time...

Hi Daniel, the V3 version of this patch (which is the same as this
version, just based on a now-older commit) was already sent to the
Xen-devel ML, as can be seen at [1], [2]. I did forget to resend the
patch to the Xen-devel ML when I resent it to Grub-devel, but it has
already had well over a month to be reviewed by the Xen team with no
response. If you wish for me to resend it again, I will do so (but not
copy the Grub-devel ML on it so as to avoid excessive noise).

[1] https://lists.xenproject.org/archives/html/xen-devel/2025-06/msg00298.html
[2] https://lists.xenproject.org/archives/html/xen-devel/2025-06/msg00299.html

--
Aaron

> Daniel
>
> On Mon, Jul 21, 2025 at 06:42:25PM -0500, Aaron Rainbolt wrote:
> > The purpose of this patch is to allow the Xen hypervisor to pass extra
> > data to GRUB in the form of a kernel command line, allowing the host to
> > customize the boot process of the guest. The command line from Xen is
> > parsed, and any variables within that start with the string
> > `xen_grub_env_` are exposed as environment variables. The grub.cfg
> > script can then use those environment variables as it sees fit.
> >
> > The main reason for doing this is to allow implementing boot modes in
> > Qubes OS while also using in-VM kernels. For more context on Qubes boot
> > modes, see [1]. In order for this to work with in-VM kernels, it is
> > necessary for dom0 to pass kernel parameters to the guest without
> > modifying the guest's grub.cfg manually. This patch allows this to be
> > done, by allowing dom0 to pass kernel parameters to GRUB, which then
> > provides them to grub.cfg as an environment variable. The grub.cfg
> > script within the VM can then append those variables to the kernel
> > command line.
> >
> > The patch's code is unchanged from the last time I sent it [2], I've
> > simply rebased it on top of the latest commit at the time of this
> > writing (0e36779). I have not run it through the full test suite used
> > previously, but I have ensured that both PV and PVH bootloaders build
> > successfully and can boot an Arch Linux virtual machine on an Arch
> > Linux host.

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to