The patch set is missing cover letter.
On Tue, May 13, 2025 at 11:03:25AM +0000, khaalid cali wrote:
> From: khaalid <khaliidca...@gmail.com>
Again, you can drop this from all patches.
> It was forgotten to free mempath entirely.
>
> Signed-off-by: Khalid Ali <khaliidca...@gmail.com>
> ---
> grub-core/loader/efi/linux.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/grub-core/loader/efi/linux.c b/grub-core/loader/efi/linux.c
> index b45a3cc61..7c7db3e3a 100644
> --- a/grub-core/loader/efi/linux.c
> +++ b/grub-core/loader/efi/linux.c
> @@ -212,8 +212,11 @@ grub_arch_efi_linux_boot_image (grub_addr_t addr,
> grub_size_t size, char *args)
> (grub_efi_device_path_t *) mempath,
> (void *) addr, size, &image_handle);
> if (status != GRUB_EFI_SUCCESS)
> + {
> + grub_free(mempath);
Wrong coding style, missing space before "(". Please fix this in all patches.
> return grub_error (GRUB_ERR_BAD_OS, "cannot load image 0x%lx", status);
This line suggests the patch adding status code to the error message
should be part of this series.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
