On Mon, May 12, 2025 at 07:15:08PM +0000, khaalid cali wrote:
> From: khaalid <khaliidca...@gmail.com>
>
> Well, i think the hex option is simpler in terms of code. Or maybe we
> need to have centralized function for all UEFI error messages, however
> this will complicate things a little bit as it requires modifications.
>
> Just thought maybe we can extract high bit and treat like integer, thus
> align close as the way spec documented.
>
> Signed-off-by: Khalid Ali<khaliidca...@gmail.com>
Missing space before "<".
> ---
> grub-core/loader/efi/chainloader.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/grub-core/loader/efi/chainloader.c
> b/grub-core/loader/efi/chainloader.c
> index 869307bf3..ecdce2393 100644
> --- a/grub-core/loader/efi/chainloader.c
> +++ b/grub-core/loader/efi/chainloader.c
> @@ -91,7 +91,7 @@ grub_chainloader_boot (void *context)
> }
> }
> else
> - grub_error (GRUB_ERR_BAD_OS, "unknown error");
> + grub_error (GRUB_ERR_BAD_OS, "cannot start image 0x%lx", status);
This is not portable. Please use relevant PRI* macros from
include/grub/efi/api.h.
> }
>
> if (exit_data)
> @@ -344,11 +344,7 @@ grub_cmd_chainloader (grub_command_t cmd __attribute__
> ((unused)),
> &image_handle);
> if (status != GRUB_EFI_SUCCESS)
> {
> - if (status == GRUB_EFI_OUT_OF_RESOURCES)
> - grub_error (GRUB_ERR_OUT_OF_MEMORY, "out of resources");
> - else
> - grub_error (GRUB_ERR_BAD_OS, "cannot load image");
> -
> + grub_error (GRUB_ERR_BAD_OS, "cannot load image 0x%lx",status);
Ditto. Same for other patches...
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
