On Tue, Mar 25, 2025 at 04:37:43PM +0100, Daniel Kiper wrote: > On Mon, Jan 13, 2025 at 11:07:08AM +0800, Gary Lin wrote: > > The following TPM 2.0 commands are introduced to tss2 to access the > > TPM non-volatile memory associated with the NV index handles. > > > > - TPM2_NV_DefineSpace > > - TPM2_NV_UndefineSpace > > - TPM2_NV_ReadPublic > > - TPM2_NV_Read > > - TPM2_NV_Write > > > > The related marshal/unmarshal functions are also introduced. > > > > Signed-off-by: Gary Lin <g...@suse.com> > > Reviewed-by: Stefan Berger <stef...@linux.ibm.com> > > Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> except one nit below... > > > diff --git a/grub-core/lib/tss2/tss2_mu.c b/grub-core/lib/tss2/tss2_mu.c > > index 86134cc0a..816e5b37f 100644 > > --- a/grub-core/lib/tss2/tss2_mu.c > > +++ b/grub-core/lib/tss2/tss2_mu.c > > @@ -17,6 +17,7 @@ > > * along with GRUB. If not, see <http://www.gnu.org/licenses/>. > > */ > > > > +#include <grub/mm.h> > > I am not sure why you include grub/mm.h... > It's because 'NULL' is defined in grub/mm.h or the compiler would complain that 'NULL' is not declared.
Gary Lin > > #include <grub/misc.h> > > > > #include <tss2_mu.h> > > Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
