On Fri, Mar 07, 2025 at 02:31:18PM +0530, Avnish Chouhan wrote: > Hi Daniel, > Thank you so much for your patch reviews. > > I'll replace the words as suggested by you.
Thank you! > **** > > > + * If we have an error or the reboot is detected as CAS reboot, > > > + * don't call CAS, just hope for the best. > > > + * Along with the above, if the rmo_top is 512 MB or above. We > > > + * will skip the CAS call. Though if we call CAS, the rmo_top > > > will > > > + * be set to 768 MB via CAS Vector2. This condition is > > > required to avoid the > > > + * issue where the older Linux kernels are still using > > > rmo_top as 512 MB. > > > + * If we call CAS where rmo_top is less then 768 MB, this > > > will result in an issue > > > + * due to IBM CAS reboot feature and we won't be able to boot > > > the newer kernel. > > > > Could you be more specific? What is "an issue due to IBM CAS reboot > > feature"? > > > > And I think it would be nice if you put here a reference to > > documentation, > > including chapters names, etc., which discuss RMA and issues fixed here. > > > > > + * The machine will boot with the last booted kernel which > > > has rmo_top as 512 MB. > > > + */ > **** > > On this. This patch only change the size of RMA from 512 MB to 768 MB. The > change is done via CAS call. Condition for calling a CAS has no change other > than adding a check on "whether the reboot is a CAS reboot". This is > required to avoid unwanted and repetitive CAS calls. OK... > With this CAS reboot check condition, in any scenario, where we are using > older kernel and CAS is still using 512 MB RMA but with the updated Grub. I am not sure I understand this sentence... > The repeated CAS calls will be avoided. > > In IBM CAS reboot feature, whenever CAS call occurred. We skip providing the Ditto... > kernel options to boot to and we directly boot to the lasted booted kernel. s/lasted/last/? > With this feature in place. If we upgrade the machine's kernel and grub, and The project name is GRUB not grub nor Grub... Please be consistent... > as the machine is lasted booted with old kernel. Any CAS call from Grub will s/lasted/last/? > restrict user to keep booting to last booted kernel! Again, I am not sure I understand this paragraph. Please rephrase it. > So these conditions are made to avoid any of these possible issues. > > on adding the documentation, we can add the PAPR document link which has > been shared with you earlier by IBM folks. That would be perfect! Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
