On Mon, Dec 30, 2024 at 10:52:23AM +0000, James Le Cuirot wrote: > From: James Le Cuirot <jlecui...@microsoft.com> > > grub_script_execute_sourcecode() parses and executes code one line at a > time, updating the return code each time because only the last line > determines the final status. However, trailing new lines were also > executed, masking any failure on the previous line. Fix this by only > trying to execute the command when there is actually one present. > > This has presumably never been noticed because this code is not used by > regular functions, only in special cases like eval and menu entries. The > latter generally don't return at all, having booted an OS. When failing > to boot, upstream GRUB triggers the fallback mechanism regardless of the > return code. > > We noticed the problem while using Red Hat's patches, which change this > behaviour to take account of the return code. In that case, a failure > takes you back to the menu rather than triggering a fallback. > > Signed-off-by: James Le Cuirot <jlecui...@microsoft.com>
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
