On Tue, Oct 22, 2024 at 10:04:25PM +0800, Daniel Kiper wrote: > On Fri, Oct 18, 2024 at 07:48:24PM +0800, Michael Chang wrote: > > On Fri, Oct 18, 2024 at 08:08:28AM GMT, zhangqiumiao wrote: > > > > On Thu, Oct 03, 2024 at 03:23:15PM +0800, Michael Chang via Grub-devel > > > > wrote: > > > >> Similar to the fix in commit "c52ae4057 efinet: skip virtual IPv4 > > > >> and > > > >> IPv6 devices during card enumeration", the UEFI PXE driver > > > >> creates additional VLAN child devices when a VLAN ID is > > > >> configured on a network interface associated with a physical NIC. > > > >> These virtual VLAN devices must be skipped during card > > > >> enumeration to ensure that the subsequent SNP exclusive open > > > >> operation targets the correct physical card instances, otherwise > > > >> packet transfer would fail. > > > >> > > > >> Example device path with VLAN nodes: > > > >> > > > >> /MAC(123456789ABC,0x1)/Vlan(20)/IPv4(0.0.0.0,0x0,DHCP,0.0.0.0,0.0 > > > >> .0.0,0.0.0.0) > > > >> > > > >> Signed-Off-by: Michael Chang <mch...@suse.com> > > > > > > > > Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> > > > > > > > > Daniel > > > > > > I submitted almost the same patch in August this year, more than a > > > month earlier than Michael Chang's patch. Why did the community > > > ignore my patch and accept his patch instead? > > > > Hi zhangqiumiao, > > > > I don't think it was intentional. There were times my patch was > > overlooked as well. With the mailing list constantly flooded with new > > patches every day, it's possible that it simply got buried and went > > unnoticed. In such cases, resending the patch might help remind the > > maintainer. > > > > > The patch I submitted in August: > > > https://www.mail-archive.com/grub-devel@gnu.org/msg38860.html > > > > Unfortunately I overlooked yours fix in the mailing list as well when > > trying to solved the reported issue (and coincidently that was > > reported on a huawei system too). > > > > Anyway, Let's ping Daniel if he can help to drop mine and commit yours. > > > > Hi Daniel, > > > > Could you please help on that ? > > As Michael said, it was not intentional. Simply I missed your patch in an > influx of other patches. Sorry > about that. If you think your patch is > better in one way or another drop us a line. > > Daniel
Hi Daniel, Could you please add 'Co-authored-by: zhangqiumi...@huawei.com' in the commit message? _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
