On Fri, Sep 13, 2024 at 04:57:59PM +0530, Sudhakar Kuppusamy wrote:
> The SBAT metadata, which is read from .csv file and transformed into an ELF
> note,
> is made into an image using the -s option.
>
> Signed-off-by: Sudhakar Kuppusamy <[email protected]>
> Co-authored-by: Daniel Axtens <[email protected]>
s/Co-authored-by/Signed-off-by/ and please reorder SOBs...
> ---
> util/mkimage.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/util/mkimage.c b/util/mkimage.c
> index e67f7ce73..bafe190b0 100644
> --- a/util/mkimage.c
> +++ b/util/mkimage.c
> @@ -943,8 +943,9 @@ grub_install_generate_image (const char *dir, const char
> *prefix,
> total_module_size += dtb_size + sizeof (struct grub_module_header);
> }
>
> - if (sbat_path != NULL && image_target->id != IMAGE_EFI)
> - grub_util_error (_(".sbat section can be embedded into EFI images
> only"));
> + if (sbat_path != NULL && (image_target->id != IMAGE_EFI &&
> image_target->id != IMAGE_PPC))
> + grub_util_error (_(".sbat section can be embedded into EFI images/"
> + "sbat ELF Note can be added into powerpc-ieee1275
> images only"));
I think "SBAT data can be added only to EFI or powerpc-ieee1275 images"
would be much better here.
Daniel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
