On Fri, Oct 04, 2024 at 03:41:27PM +0100, Mate Kukri wrote:
> For NX, we need to set the page access permission attributes for write
> and execute permissions.
>
> This patch adds two new primitives, grub_set_mem_attrs() and
> grub_clear_mem_attrs(), and associated constant definitions, to be used
> for that purpose.
>
> For most platforms, it adds a dummy implementation.
>
> On EFI platforms, it implements the primitives using the EFI
> Memory Attribute Protocol (defined in UEFI 2.10 specification).
>
> Signed-off-by: Peter Jones <pjo...@redhat.com>
> Signed-off-by: Jan Setje-Eilers <jan.setjeeil...@oracle.com>
> Signed-off-by: Mate Kukri <mate.ku...@canonical.com>
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>
Though one nit below...
> +grub_err_t
> +grub_update_mem_attrs (grub_addr_t addr, grub_size_t size,
> + grub_mem_attr_t set_attrs, grub_mem_attr_t clear_attrs)
> +{
> + grub_efi_memory_attribute_protocol_t *proto;
> + grub_efi_physical_address_t physaddr = addr;
> + static grub_guid_t protocol_guid = GRUB_EFI_MEMORY_ATTRIBUTE_PROTOCOL_GUID;
> + grub_efi_status_t efi_status = GRUB_EFI_SUCCESS;
> + grub_efi_uint64_t uefi_set_attrs, uefi_clear_attrs;
> +
> +
... redundant empty line...
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
