I didn't see a reason to ever see this either, hence I added no
dprintf (also i think "loader" isn't an existing dprintf name, and I
try to avoid introducing those as much as I can).
By "explicitly asking for", I was thinking of the ability to simply
print the path in the config (which admittedly isn't exactly the same
thing as an UEFI device path).
On Mon, Aug 12, 2024 at 11:54 PM Heinrich Schuchardt
<heinrich.schucha...@canonical.com> wrote:
>
> On 8/2/24 12:52, Mate Kukri wrote:
> > Users have no reason to see this without explicitly asking for it, and
> > it can break graphical boot.
>
> If you wanted users to be able to explicitly ask for the the output, you
> could use:
>
> grub_dprintf ("loader", ...)
>
> 'set debug=loader' then would provide the output.
>
> But I don't see good reason to require such debug output.
>
> Acked-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
>
> >
> > Signed-off-by: Mate Kukri <mate.ku...@canonical.com>
> > ---
> > grub-core/loader/efi/chainloader.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/grub-core/loader/efi/chainloader.c
> > b/grub-core/loader/efi/chainloader.c
> > index eb833b678..11b64ac1b 100644
> > --- a/grub-core/loader/efi/chainloader.c
> > +++ b/grub-core/loader/efi/chainloader.c
> > @@ -183,7 +183,6 @@ make_file_path (grub_efi_device_path_t *dp, const char
> > *filename)
> > /* Fill the file path for the directory. */
> > d = (grub_efi_device_path_t *) ((char *) file_path
> > + ((char *) d - (char *) dp));
> > - grub_efi_print_device_path (d);
> > if (copy_file_path ((grub_efi_file_path_device_path_t *) d,
> > dir_start, dir_end - dir_start) != GRUB_ERR_NONE)
> > {
> > @@ -270,9 +269,6 @@ grub_cmd_chainloader (grub_command_t cmd __attribute__
> > ((unused)),
> > file_path = make_file_path (dp, filename);
> > if (file_path == NULL)
> > goto fail;
> > -
> > - grub_printf ("file path: ");
> > - grub_efi_print_device_path (file_path);
> > }
> >
> > size = grub_file_size (file);
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
