Silently keeping entries in the list if the address matches, but the
page count doesn't is a bad idea, and can lead to double frees.
grub_efi_free_pages() have already freed parts of this block by this
point, and thus keeping the whole block in the list and freeing it again
at exit can lead to double frees.
Signed-off-by: Mate Kukri <mate.ku...@canonical.com>
---
grub-core/kern/efi/mm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/grub-core/kern/efi/mm.c b/grub-core/kern/efi/mm.c
index 661319194..d45d0e2ac 100644
--- a/grub-core/kern/efi/mm.c
+++ b/grub-core/kern/efi/mm.c
@@ -95,8 +95,10 @@ grub_efi_drop_alloc (grub_efi_physical_address_t address,
for (eap = NULL, ea = efi_allocated_memory; ea; eap = ea, ea = ea->next)
{
- if (ea->address != address || ea->pages != pages)
- continue;
+ if (ea->address != address)
+ continue;
+ if (ea->pages != pages)
+ grub_fatal ("grub_efi_drop_alloc() called with wrong page count");
/* Remove the current entry from the list. */
if (eap)
--
2.39.2
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
