On Wed, Jul 26, 2023 at 03:59:58PM -0500, Glenn Washburn wrote: > This patch series (for me) was motivated by the "gdb: Add more support for > debugging on EFI platforms" patch series, which allowed printing in early > EFI init of the GDB command for properly loading symbols. That approach of > having the functionality be included at compile time was ultimately > rejected. During the discussion of that series, Robbie suggested[1] using > patches by Peter and in the Redhat downstream repo which uses an EFI > variable to store a GRUB env block. Using this, a user could store a > variable in the env block stored in the EFI variable and then have GRUB > load that env block in early init as a way to enable the printing of the > GDB command. > > I've taken the original patches by Peter, made more suitable for including > in GRUB, fixed some bugs, and added a minor feature. The first patch, adds > env block loading in early EFI init from the GRUB_ENV EFI variable. The > second patch is included to provide tools for GRUB to set this EFI env > block itself, as opposed to needing to use the method suggested by > Robbie[1], which requires GNU/Linux and the user-space grub2-editenv > utility. Of course, if GRUB is crashing before one can run the > efi-export-env command, then other ways of creating and setting the EFI > envblk variable are necessary. The third patch adds a test which checks the > usability of the commands and the early init loading. And the last patch, > whichvmotivated this series, prints the GDB command string if the GRUB > variable named "enable_earlyinit_gdbinfo" is present and is set to "1", after > the env block is loaded from the GRUB_ENV EFI variable. We might want a > different name for the GRUB variable, I don't really have a preference.
I am torn apart. On one hand it is nice feature. On the other hand it requires a lot of changes. So, I would prefer to defer merging this thing after the release. Until you convince me I should do otherwise... Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
