On Tue, Aug 15, 2023 at 03:00:53PM +0100, Anthony PERARD via Grub-devel wrote: > It turns out that setting $xen_version in linux_entry_xsm() override > $xen_version in the loop over $xen_list. This means that only one
s/xen_list/reverse_sorted_xen_list/? I expect you based your patch on earlier version of the GRUB which used $xen_list in fact. Did not you? And this brings another question. Is this patched based on latest GRUB git master branch? > entry per Xen version is going to enable XSM, but all further entries > are going to have "(XSM enabled)" in their titles without enabling > XSM. > > When a "xenpolicy-$xen_version" file was found for the current > $xen_version, it would be overwrite $xen_version to add "(XSM s/be// > enabled)" to the menu entry title. Once change, the next call to s/change/updated/? > linux_entry_xsm() would also have this modified $xen_version and would > look for the file "xenpolicy-*(XSM enabled)" and fail. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> Otherwise patch LGTM... Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
