On Thu, Aug 31, 2023 at 09:53:54AM +0000, Vitaly Kuzmichev wrote: > Hi Daniel, > > On Wed, 2023-08-30 at 16:26 +0200, Daniel Kiper wrote: > > Adding Daan who sent similar patch a day earlier... > > > > On Tue, Aug 22, 2023 at 11:39:08PM +0200, Vitaly Kuzmichev wrote: > > > Improve 'search' grub-shell command with functionality to search > > > for > > > a partition by PARTUUID and PARTLABEL strings. This is useful for > > > embedded systems where FSUUID is not guaranteed to be constant, > > > e.g. > > > it is not preserved between system updates, and modifying grub.cfg > > > is undesired. > > > > > > Signed-off-by: Vitaly Kuzmichev <vitaly.kuzmic...@rtsoft.de> > > > > Vitaly, Daan, sorry, this patch set is too intrusive to get it in > > this > > stage of GRUB development. Right now we are focusing on fixing > > various > > issues before the release. We stopped taking new features before > > 2.12~rc1 > > cut. Though I would be more than happy to review and take the patch > > set > > after the release. > > Ok. > Please consider to include "[PATCH v5 04/16] include/grub/misc.h: Fix > edge case in grub_uuidcasecmp()" [1], which is a bugfix for existing > code. > Should I send it separately?
No, you should not if you agree with my comment and conditional RB... > I think it makes sense to fold some patches together, so that if any of > distro maintainers would like to include this functionality, they would > not need to deal with so many patches. Sorry, I cannot comment on that because I did not have a time to take a look at the patches. I will take a look at them after the release. Maybe if others has some time will take a look at the patch set earlier. I think you should consider taking into account Vladimir's comments... Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
