On Fri, Apr 28, 2023 at 04:39:24PM +0200, Daniel Kiper wrote:
> On Thu, Apr 27, 2023 at 03:42:59PM +0800, Xiaotian Wu wrote:
> > LoongArch is a new Loongson 3A5000 CPU instruction set, you can read
> > documents [1] or visit the development community [2] to get more
> > information.
> >
> > [1]: https://loongson.github.io/LoongArch-Documentation/README-EN.html
> > [2]: https://github.com/loongson
> >
> > This patch series adds support for the Loongarch architecture, which can
> > compile and run the linux-6.2+ kernel on LoongArch.
> >
> > Please review the patches, thank you.
>
> For all the patches Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>...
I have just pushed this to the GRUB git repo but the Coverity build
of x86_64-efi reported some problems in LoongArch code. Please fix
these issues...
Daniel
Hi,
Please find the latest report on new defect(s) introduced to GRUB found with
Coverity Scan.
2 new defect(s) introduced to GRUB found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 407778: Integer handling issues (BAD_SHIFT)
/grub-core/kern/loongarch64/dl_helper.c: 86 in grub_loongarch64_sop_sr()
________________________________________________________________________________________________________
*** CID 407778: Integer handling issues (BAD_SHIFT)
/grub-core/kern/loongarch64/dl_helper.c: 86 in grub_loongarch64_sop_sr()
80 void
81 grub_loongarch64_sop_sr (grub_loongarch64_stack_t stack)
82 {
83 grub_uint64_t a, b;
84 b = grub_loongarch64_stack_pop (stack);
85 a = grub_loongarch64_stack_pop (stack);
>>> CID 407778: Integer handling issues (BAD_SHIFT)
>>> In expression "a >> b", shifting by a negative amount has undefined
>>> behavior. The shift amount, "b", is -1.
86 grub_loongarch64_stack_push (stack, a >> b);
87 }
88
89 /* opr2 = pop (), opr1 = pop (), push (opr1 + opr2) */
90 void
91 grub_loongarch64_sop_add (grub_loongarch64_stack_t stack)
** CID 407777: Integer handling issues (BAD_SHIFT)
/grub-core/kern/loongarch64/dl_helper.c: 76 in grub_loongarch64_sop_sl()
________________________________________________________________________________________________________
*** CID 407777: Integer handling issues (BAD_SHIFT)
/grub-core/kern/loongarch64/dl_helper.c: 76 in grub_loongarch64_sop_sl()
70 void
71 grub_loongarch64_sop_sl (grub_loongarch64_stack_t stack)
72 {
73 grub_uint64_t a, b;
74 b = grub_loongarch64_stack_pop (stack);
75 a = grub_loongarch64_stack_pop (stack);
>>> CID 407777: Integer handling issues (BAD_SHIFT)
>>> In expression "a << b", shifting by a negative amount has undefined
>>> behavior. The shift amount, "b", is -1.
76 grub_loongarch64_stack_push (stack, a << b);
77 }
78
79 /* opr2 = pop (), opr1 = pop (), push (opr1 >> opr2) */
80 void
81 grub_loongarch64_sop_sr (grub_loongarch64_stack_t stack)
________________________________________________________________________________________________________
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
