On Fri, Mar 17, 2023 at 03:08:11PM +0530, Avnish Chouhan wrote: > This patch enables the multiple options in Options Vector5.
May I ask you to add an explanation to the commit message why this patch is needed? Additionally, please name and, at least shortly, explain all added options. > Signed-off-by: Avnish Chouhan <avn...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> I have not seen Brian adding this in public. Please do not add any RBs which were never ever given in public. > --- > grub-core/kern/ieee1275/init.c | 43 > ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 42 insertions(+), 1 deletion(-) > > diff --git a/grub-core/kern/ieee1275/init.c b/grub-core/kern/ieee1275/init.c > index 7337e28..6f0eeee 100644 > --- a/grub-core/kern/ieee1275/init.c > +++ b/grub-core/kern/ieee1275/init.c > @@ -72,6 +72,42 @@ extern char _end[]; > grub_addr_t grub_ieee1275_original_stack; > #endif > > +/* Options vector5 properties */ > + > +#define LPAR 0x80 > +#define SPLPAR 0x40 > +#define DYN_RCON_MEM 0x20 > +#define LARGE_PAGES 0x10 > +#define DONATE_DCPU_CLS 0x2 s/0x2/0x02/ > +#define PCI_EXP 0x1 s/0x1/0x01/ > +#define BYTE2 (LPAR | SPLPAR | DYN_RCON_MEM | LARGE_PAGES | > DONATE_DCPU_CLS | PCI_EXP) > + > +#define CMOC 0x80 > +#define EXT_CMO 0x40 > +#define CMO (CMOC | EXT_CMO) > + > +#define ASSOC_REF 0x80 > +#define AFFINITY 0x40 > +#define NUMA 0x20 > +#define ASSOCIATIVITY (ASSOC_REF | AFFINITY | NUMA) > + > +#define HOTPLUG_INTRPT 0x4 > +#define HPT_RESIZE 0x1 Please add as many zeros as needed before [14] as above. And now I think I would split this patch into two. In the first patch I would convert existing plain numbers to constants. Then I would add new options in the second patch. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
