Hi Oskari, On Fri, Sep 30, 2022 at 01:53:59AM -0500, Oskari Pirhonen wrote: > > I'm not too familiar with what end-users might want. If we want to make > > this more universal, we could either do GRUB_TOP_LEVEL_KERNEL and have > > that shared amongst all of the 10_* files or we could have multiple > > variables, e.g. GRUB_TOP_LEVEL_LINUX, GRUB_TOP_LEVEL_BSD, etc. > > > > A single GRUB_TOP_LEVEL or something is what I was thinking. I'm not > familiar with Xen, but based on your original patch, it may warrant its > own.
I'm not familiar with Xen either. My understanding is that there can be parallel top-level entries so it deserves its own variable. > > > - What about for os-prober? My understanding is that it creates its own > > > top level entries as well. > > > > The same thing could work with os-prober, although it wouldn't be a > > cut-and-paste. > > > > os-prober would probably have its own GRUB_TOP_LEVEL_OS_PROBER or > something as well. Sounds good! > > I'm open to all ideas here and I can cook up the patches. The thing is > > that I'm not sure what the project's conventions are regarding > > too-granular/not-granular-enough configurations so some advice here > > would be very much appreciated! > > > > Generating a config for multiple OS's would use os-prober, so a single > "main" variable for top level entries would be simpler and should be > enough IMO. Thanks for the feedback! Patch coming soon. -Denton _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
