On Thu, Sep 22, 2022 at 07:18:50PM +0200, Daniel Kiper wrote: >On Sun, Sep 18, 2022 at 11:12:02PM +0100, Steve McIntyre wrote: >> In some filesystem utils like mksquashfs, they will silently change >> behaviour and cause timestamps to unexpectedly change. Build >> environments like Debian's set SOURCE_DATE_EPOCH in the environment, >> so remove it. Reproducible builds are good and useful for shipped >> artifacts, but this causes build-time tests to fail. >> >> Signed-off-by: Steve McIntyre <st...@einval.com> > >Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> but... > >> --- >> tests/util/grub-fs-tester.in | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in >> index 43f6175c3..6d70967e6 100644 >> --- a/tests/util/grub-fs-tester.in >> +++ b/tests/util/grub-fs-tester.in >> @@ -5,6 +5,9 @@ export BLKID_FILE=/dev/null >> >> fs="$1" >> >> +# We can't have this set, or filesystem tests will fail >> +unset SOURCE_DATE_EPOCH >> + > >... I would put this change before fs assignment above. It would be next >to export and look more logically. At least for me... :-) If you do not >object I will make this change before applying the patch.
Sure, go for it. :-) -- Steve McIntyre, Cambridge, UK. st...@einval.com You raise the blade, you make the change... You re-arrange me 'til I'm sane... _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
