Adding Chris... On Tue, Jun 14, 2022 at 06:19:00PM -0400, Nicholas Vinson wrote: > Previous version of configure.ac would error out when > --enable-stack-protector was given and a selected GRUB platform did not > support the flag. The new behavior is to warn that the flag is not > supported and force disable it for that platform.
Could you explain why do we need this change? I think it is safer to fail in this case than warn. > Signed-off-by: Nicholas Vinson <nvinson...@gmail.com> > --- > configure.ac | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 57fb70945..9bdc102b2 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1349,7 +1349,8 @@ if test "x$enable_stack_protector" = xno; then > TARGET_CFLAGS="$TARGET_CFLAGS -fno-stack-protector" > fi > elif test "x$platform" != xefi; then > - AC_MSG_ERROR([--enable-stack-protector is only supported on EFI platforms]) > + AC_MSG_WARN([--enable-stack-protector is only supported on EFI platforms]) > + enable_stack_protector=no > elif test "x$ssp_global_possible" != xyes; then > AC_MSG_ERROR([--enable-stack-protector is not supported (compiler doesn't > support -mstack-protector-guard=global)]) > else > -- > 2.35.1 Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
