On Mon, Mar 28, 2022 at 05:22:34PM +1100, Daniel Axtens wrote: > From: Patrick Steinhardt <p...@pks.im> > > The function `add_memory_regions ()` is currently only called on system > initialization to allocate a fixed amount of pages. As such, it didn't > need to return any errors: in case it failed, we cannot proceed anyway. > This will change with the upcoming support for requesting more memory > from the firmware at runtime, where it doesn't make sense anymore to > fail hard. > > Refactor the function to return an error to prepare for this. Note that > this does not change the behaviour when initializing the memory system > because `grub_efi_mm_init ()` knows to call `grub_fatal ()` in case > `grub_efi_mm_add_regions ()` returns an error. > > Signed-off-by: Patrick Steinhardt <p...@pks.im> > [dja: clarify error messages] > Signed-off-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
