Define MM_DEBUG in config.h when --enable-mm-debug is passed to configure.
It was being defined in config-util.h which only gets used when building
GRUB utilities for the host side. The enabling of debugging for memory
management in include/grub/mm.h explicitly does not happen when compiling
for the GRUB utilities. So this debugging code effectively could never be
enabled. Note, that MM_DEBUG is defined in an #if directive because the
enabling of debugging checks if MM_DEBUG is defined, not what its value is.
So even if MM_DEBUG were defined to nothing, the debugging code would
still be enabled.
Signed-off-by: Glenn Washburn <developm...@efficientek.com>
---
config.h.in | 4 ++++
configure.ac | 6 ++++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/config.h.in b/config.h.in
index 9e8f9911b1..c1323a88e3 100644
--- a/config.h.in
+++ b/config.h.in
@@ -9,6 +9,10 @@
#define GCRYPT_NO_DEPRECATED 1
#define HAVE_MEMMOVE 1
+#if @MM_DEBUG@
+#define MM_DEBUG @MM_DEBUG@
+#endif
+
/* Define to 1 to enable disk cache statistics. */
#define DISK_CACHE_STATS @DISK_CACHE_STATS@
#define BOOT_TIME_STATS @BOOT_TIME_STATS@
diff --git a/configure.ac b/configure.ac
index 5c01af0fab..65d7f8a3be 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1519,9 +1519,11 @@ AC_ARG_ENABLE([mm-debug],
AS_HELP_STRING([--enable-mm-debug],
[include memory manager debugging]))
if test x$enable_mm_debug = xyes; then
- AC_DEFINE([MM_DEBUG], [1],
- [Define to 1 if you enable memory manager debugging.])
+ MM_DEBUG=1
+else
+ MM_DEBUG=0
fi
+AC_SUBST([MM_DEBUG])
AC_ARG_ENABLE([cache-stats],
AS_HELP_STRING([--enable-cache-stats],
--
2.27.0
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
