On Mon, Dec 20, 2021 at 11:40:10PM +0100, Daniel Kiper wrote:
> On Thu, Dec 09, 2021 at 11:14:49AM -0600, Glenn Washburn wrote:
> > Updates since v4:
> > * Rework patch #2 to (hopefully) be easier to understand
> > * Add more commentary to patch #2 commit message
> > * Split previous patch #3 into three separate patches
> >
> > ---
> > This patch series refactors the way cryptomount passes data to the crypto
> > modules. Currently, the method has been by global variable and function call
> > argument, neither of which are ideal. This method passes data via a
> > grub_cryptomount_args struct, which can be added to over time as opposed to
> > continually adding arguments to the cryptodisk recover_key (as is being
> > proposed in the keyfile and detached header patches).
>
> Whole patch series looks good to me. I am going to merge it no later
> than on Thursday this week.
I have applied the patch set conditionally due to this Coverity report:
*** CID 366905: Memory - illegal accesses (USE_AFTER_FREE)
/grub-core/disk/cryptodisk.c: 1064 in grub_cryptodisk_scan_device_real()
1058 cleanup:
1059 if (askpass)
1060 {
1061 cargs->key_len = 0;
1062 grub_free (cargs->key_data);
1063 }
>>> CID 366905: Memory - illegal accesses (USE_AFTER_FREE)
>>> Using freed pointer "dev".
1064 return dev;
1065 }
1066
1067 #ifdef GRUB_UTIL
1068 #include <grub/util/misc.h>
1069 grub_err_t
Glenn, please fix this after holiday.
James, I think you can rabase your patch set on the latest master now.
The issue mentioned above should not impact your work.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
