Hi Mislav, On Tue, Sep 21, 2021 at 03:37:45PM +0000, Mislav Stublić wrote: > Hi, > > This implements device tree support for x86. Unfortunately I haven't > been able to test this on latest master but I have tested against 2.04 > and it works fine. I will test on master later but I wanted to get > some initial comments if this is going in the right direction. What I > haven't tested is firmware DTB loading support which only calls > grub_efi_get_firmware_fdt from kern/efi implementation as I don't have > hardware to test this scenario.
I skimmed through your patch and it seems to me you are duplicating at least some code from grub-core/loader/arm/linux.c. I would do this a bit differently. First of all I would factor out non-UEFI device tree code from grub-core/loader/arm/linux.c to a separate module. This should be a separate patch. Then I would try to unify the interface for UEFI and non-UEFI device tree code (again, separate patch). Of course if needed. Then the last patch should add device tree support to the x86. If you have any questions drop me a line. Anyway, thank you for taking a stab at this. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
