On Mon, Aug 30, 2021 at 11:53:17AM +0200, Petr Vorel wrote: > It help to avoid error on distros which has only python3 binary: > ./autogen.sh: line 20: python: command not found > > Use python3 as the default as python2 is EOL since Jan 2020, but check > also python which is on most distros if not all python2 because > code still works on python2. > > Although it should not be needed keep the possibility to define PYTHON. > > For detection use "command -v" which is POSIX [3] and supported on all > common shells (bash, zsh, dash, busybox sh, mksh) instead requiring > "which" as extra dependency (usable on containers). > > Update INSTALL. > > Signed-off-by: Petr Vorel <pvo...@suse.cz>
I think you missed some minor requests from previous review. I can fix them before committing. Anyway, Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> for both patches... Thank you for fixing these issues. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
