On Wed, Mar 03, 2021 at 07:43:23PM +0100, John Paul Adrian Glaubitz wrote: > Hi Daniel! > > On 3/3/21 2:13 PM, Daniel Kiper wrote: > >> This is confusing: now to get boot entries from os-prober one have to > >> set: > >> GRUB_DISABLE_OS_PROBER=true > >> in /etc/default/grub. > >> > >> Either revert that, or (better, in my opinion) label the variable > >> GRUB_ENABLE_OS_PROBER and set it to false by default. > > > > When we worked on this patch we considered that. However, after some > > thinking we stated that renaming to GRUB_ENABLE_OS_PROBER will make > > more confusion. So, we decided to stick to existing name even if it > > is not the best one. > > I'm not sure I'm able to follow the motivation to keep the naming scheme > as is. > > If I have an option called "DISABLE_FEATURE_X", then I would expect setting > it to "true" would mean that the feature is disabled not the other way around.
Huh! I have just realized that we did not drop "if" change from earlier version of patch which also changed variable name. Interestingly doc update is correct. Anyway, sorry for the confusion. I asked Alex to post a fix for this. Daniel _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
