Hi Patrick, > On Tue, Jan 19, 2021 at 02:06:15PM +0100, Petr Vorel wrote: > > Hi,
> > > Please try to build only for the "efi-64" platform. (not "pc") > > right, I'll test it, but we need to support also legacy bios. > I wasn't aware it wouldn't build on the "pc" platform, but I never even > tried in the first place. The patch series definitely needs more > polishing anyway, but thanks for making me aware. Thanks! One more note: "Argon2 not supported" is not shown, instead there is "Invalid encryption" printed later in luks2_recover_key(). It was trivial to modify sources to find it, but that will not be user friendly for users which will run grub2 from distro package. > > BTW as Argon2 is the default PBKDF algorithm in current cryptsetup, Debian > > installer (and probably other distros' installers) uses it and it has to be > > converted after installation with Live CD / connecting HDD on different > > machine. > > Therefore postponing Argon2 to another release means users will have it in > > 2+ > > years after 2.06 release (unless distros backport it). > That cannot be helped, unfortunately. The current release has been > taking far too long already, and delaying it even further will > completely bar anybody from using LUKS2 with GRUB in the first place. Sure, understand. > I don't really know about the release cycle, but personally I wouldn't > mind to accelerate it. That's only my two cents though as somebody who > hasn't been involved in the project that deeply. +1 (that would allow to greatly reduce number of patches in distros, but understand the lack of maintainers time). Kind regards, Petr > Patrick _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
