On Thu, 2020-04-16 at 21:18 +0000, Chen, Zide wrote: > > > > Hi Zide > > > > Above modification changes another behavior. Before your patch, lowest > > address for multiboot2 modules allocation was 0x0, now, when you removed > > #ifndef, it is set to 1MB even if quirk is not enabled. I think that it > > is worth to mention than in commit message. > > > > To be honest, I was going to submit patch that sets lowest_addr to > > 0x1000 by default, so from my perspective your 'undocumented' change is > > good, 1MB works for my project too. > > > > Thanks, > > Lukasz > > Hi Lukasz, > > I will abandon this patch for now and go to the path to add a new module > relocatable tag. > If you want you can go ahead to submit your patch to set lowest_addr, which is > independent to my new approach. > > -Zide >
Hi Zide Your new tag will work for me too, because I can set min address there. Thanks, Lukasz _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
