Hello Vladimir,
Thanks a lot for your feedback.
On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote:
> Please evaluate size increase for this. In the past passing file and line
> number to grub_dprintf was a huge source of increased Kern and core size
>
> Le mer. 4 mars 2020 à 13:01, Javier Martinez Canillas <javi...@redhat.com>
> a écrit :
>
For a x86_64-pc build with platform=pc on master with and without the patch:
$ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$
2740 total
$ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$
2756 total
so in this case the increase is a 0.6% in size.
And doing the same in a x86_64 with platform=efi build:
$ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$
4296 total
$ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$
4356 total
The size increase it's a little bigger but just a 1.4%.
You are right that there's a size increase but I wouldn't call it huge and
I think that's a good trade off for the convenience of having that info.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
