Hello Daniel, On 10/15/19 4:37 PM, Daniel Kiper wrote: > On Sat, Oct 05, 2019 at 12:44:24AM +0200, Javier Martinez Canillas wrote: >> Hello, >> >> This series contains some patches that have been carried in Fedora (and >> other distros) for a long time. It allows to fetch GRUB configurations >> that are customized for each machine by using the client UUID, MAC and >> IP addresses as suffixes for the grub.cfg file. >> >> This procedure is similar to what is used by pxelinux and yaboot: >> http://www.syslinux.org/wiki/index.php/PXELINUX#config >> >> Patch #1 sets net_<interface>_client{id,uuid} environment variables by >> using the DHCP client ID and UUID options if these are found. >> >> Patch #2 adds a %X format specifier to make the grub_printf() function >> more similar to printf() and not require to use %x plus grub_toupper(). >> >> Finally Patch #3 adds the support to fetch the config files using the >> UUID, MAC and IP as suffixes. If these aren't found, the default GRUB >> config filename is used as a fallback. > > Except some nitpicks LGTM. You can repost the patch series or I can > fix these minor things before applying. >
Thanks for the feedback. I've posted a v2 that addresses all the issues you pointed out. Please let me know if anything else is missing. > Daniel > Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
